Sender: akolli=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 25 Nov 2021 16:45:25 +0530
From:   Anilkumar Kolli <akolli@codeaurora.org>
To:     Sven Eckelmann <sven@narfation.org>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
        devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v5 2/2] ath11k: Use reserved host DDR addresses from DT
 for PCI devices
In-Reply-To: <74442923.uYUSDj6SXF@ripper>
References: <1637666940-30548-1-git-send-email-akolli@codeaurora.org>
 <1637666940-30548-2-git-send-email-akolli@codeaurora.org>
 <74442923.uYUSDj6SXF@ripper>
Message-ID: <e91487019f490b35940da8813c79cf40@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-11-23 18:31, Sven Eckelmann wrote:
> On Tuesday, 23 November 2021 12:29:00 CET Anilkumar Kolli wrote:
>> +                       ret = of_property_read_u32(dev->of_node, 
>> "memory-region",
>> +                                                  &hremote_phandle);
>> +                       if (ret) {
>> +                               ath11k_dbg(ab, ATH11K_DBG_QMI,
>> +                                          "qmi fail to get hremote 
>> phandle\n");
>> +                               return ret;
>> +                       }
>> +
>> +                       hremote_node = 
>> of_find_node_by_phandle(hremote_phandle);
>> +                       if (!hremote_node) {
>> +                               ath11k_dbg(ab, ATH11K_DBG_QMI,
>> +                                          "qmi fail to get 
>> hremote_node\n");
>> +                               return ret;
>> +                       }
> 
> Afaik, this can be combined via
> 
>     hremote_node = of_parse_phandle(dev->of_node, "memory-region", 0);
> 
Yes Sven, I will update in next version.

Thanks
Anil.