Date:   Fri, 26 Nov 2021 16:26:13 +0100
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org,
        lorenzo.bianconi@redhat.com, sean.wang@mediatek.com,
        ryder.lee@mediatek.com
Subject: Re: [PATCH wireless-drivers] mt76: fix possible pktid leak
Message-ID: <YaD8lT5csiLvmBzS@lore-desk>
References: <a560caffcc24452fb48af53904bbe5c45ea5db93.1637602268.git.lorenzo@kernel.org>
 <163777451567.4686.3609119971518562275.kvalo@codeaurora.org>
 <YaDo21+/MBeeuTDN@lore-desk>
 <87fsrj3qxo.fsf@codeaurora.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="azYq2eXH+Xd4ojZx"
Content-Disposition: inline
In-Reply-To: <87fsrj3qxo.fsf@codeaurora.org>
Precedence: bulk


--azYq2eXH+Xd4ojZx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>=20
> >> Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> >>=20
> >> > Fix a possible idr pkt-id leak if the packet is dropped on tx side
> >> >=20
> >> > Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
> >> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> >> > Acked-by: Felix Fietkau <nbd@nbd.name>
> >>=20
> >> Patch applied to wireless-drivers.git, thanks.
> >>=20
> >> 2a9e9857473b mt76: fix possible pktid leak
> >
> > Hi Kalle,
> >
> > Unfortunately I found a regression introduced by this patch for mt7663u=
 (and I
> > guess for mt7921s as well). Do you want me to post a fix or just a v2?
>=20
> I don't rebase my trees, so please post a fix. I was planning to submit
> a pull request to net tree today, but is this so serious that I should
> skip that?

I have already tested mt7663u but I do not have mt7921s hw for testing (but=
 the
behaviour should be the same). I guess we can split the patch, just post the
fix for mt7663u and let Sean the time to test it on mt7921s (I am not sure
mt7921s is already available on the market). In this way you can send the PR
today. What do you think?

Regards,
Lorenzo

>=20
> --=20
> https://patchwork.kernel.org/project/linux-wireless/list/
>=20
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa=
tches

--azYq2eXH+Xd4ojZx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYaD8lQAKCRA6cBh0uS2t
rDaMAP9OF7kn9oWS5pOFHBiD0m0Jig8oiSe+uLWIHOMrOfElKAEA/6hDI0PTHVdl
bAfDI36heuYvN3k9go8U3ezyouYV9w8=
=mZZj
-----END PGP SIGNATURE-----

--azYq2eXH+Xd4ojZx--