Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 09C5BC4338F
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] rtw88: add debugfs to fix tx rate
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20200313065114.23433-1-yhchuang@realtek.com>
References: <20200313065114.23433-1-yhchuang@realtek.com>
To:     <yhchuang@realtek.com>
Cc:     <linux-wireless@vger.kernel.org>, <briannorris@chromium.org>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <163794357152.10370.14049415292167225860.kvalo@codeaurora.org>
Date:   Fri, 26 Nov 2021 16:19:36 +0000 (UTC)
Precedence: bulk

<yhchuang@realtek.com> wrote:

> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> 
> It is useful to fix the bit rate of TX packets. For example, if
> someone is measuring the TX power, or debugging with the issues
> of the TX throughput on the field.
> 
> To set the value of fixed rate, one should input corresponding
> desc rate index (ex, 0x0b for DESC_RATE54M to fix at 54 Mbps).
> Set a value larger than DESC_RATE_MAX will disable fix rate, so
> the rate adaptive mechanism can resume to work.
> 
> Example,
>   To fix rate at MCS 1:
>   echo 0x0d > /sys/kernel/debug/ieee80211/phy0/rtw88/fix_rate
> 
>   To not to fix rate:
>   echo 0xff > /sys/kernel/debug/ieee80211/phy0/rtw88/fix_rate
> 
>   To know which rate was fixed at:
>   cat /sys/kernel/debug/ieee80211/phy0/rtw88/fix_rate
> 
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> Tested-by: Brian Norris <briannorris@chromium.org>

So the concensus was that doing this from debugfs is ok, but
unfortunately this doesn't apply anymore. Please respin.

Recorded preimage for 'drivers/net/wireless/realtek/rtw88/tx.c'
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: rtw88: add debugfs to fix tx rate
Using index info to reconstruct a base tree...
M	drivers/net/wireless/realtek/rtw88/debug.c
M	drivers/net/wireless/realtek/rtw88/main.c
M	drivers/net/wireless/realtek/rtw88/main.h
M	drivers/net/wireless/realtek/rtw88/tx.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/net/wireless/realtek/rtw88/tx.c
CONFLICT (content): Merge conflict in drivers/net/wireless/realtek/rtw88/tx.c
Auto-merging drivers/net/wireless/realtek/rtw88/main.h
Auto-merging drivers/net/wireless/realtek/rtw88/main.c
Auto-merging drivers/net/wireless/realtek/rtw88/debug.c
Patch failed at 0001 rtw88: add debugfs to fix tx rate

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20200313065114.23433-1-yhchuang@realtek.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches