Date:   Fri, 26 Nov 2021 17:23:06 +0100
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org,
        lorenzo.bianconi@redhat.com, sean.wang@mediatek.com,
        ryder.lee@mediatek.com
Subject: Re: [PATCH wireless-drivers] mt76: fix possible pktid leak
Message-ID: <YaEJ6hQ0uC32+Mts@lore-desk>
References: <a560caffcc24452fb48af53904bbe5c45ea5db93.1637602268.git.lorenzo@kernel.org>
 <163777451567.4686.3609119971518562275.kvalo@codeaurora.org>
 <YaDo21+/MBeeuTDN@lore-desk>
 <87fsrj3qxo.fsf@codeaurora.org>
 <YaD8lT5csiLvmBzS@lore-desk>
 <87sfvij4eh.fsf@codeaurora.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="0jlUeta7muUdJbMT"
Content-Disposition: inline
In-Reply-To: <87sfvij4eh.fsf@codeaurora.org>
Precedence: bulk


--0jlUeta7muUdJbMT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>=20
> >> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> >>=20
> >> >> Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> >> >>=20
> >> >> > Fix a possible idr pkt-id leak if the packet is dropped on tx side
> >> >> >=20
> >> >> > Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
> >> >> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> >> >> > Acked-by: Felix Fietkau <nbd@nbd.name>
> >> >>=20
> >> >> Patch applied to wireless-drivers.git, thanks.
> >> >>=20
> >> >> 2a9e9857473b mt76: fix possible pktid leak
> >> >
> >> > Hi Kalle,
> >> >
> >> > Unfortunately I found a regression introduced by this patch for mt76=
63u (and I
> >> > guess for mt7921s as well). Do you want me to post a fix or just a v=
2?
> >>=20
> >> I don't rebase my trees, so please post a fix. I was planning to submit
> >> a pull request to net tree today, but is this so serious that I should
> >> skip that?
> >
> > I have already tested mt7663u but I do not have mt7921s hw for testing =
(but the
> > behaviour should be the same). I guess we can split the patch, just pos=
t the
> > fix for mt7663u and let Sean the time to test it on mt7921s (I am not s=
ure
> > mt7921s is already available on the market). In this way you can send t=
he PR
> > today. What do you think?
>=20
> I think it's best to wait, I prefer to have proper build testing on my
> tree before I submit the pull request.

ack, fine to me. Let's wait for Sean in this case.

Regards,
Lorenzo

>=20
> --=20
> https://patchwork.kernel.org/project/linux-wireless/list/
>=20
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa=
tches

--0jlUeta7muUdJbMT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYaEJ6gAKCRA6cBh0uS2t
rKWNAQCx4kXVMUxGJnwCQTkziK1f4UR+vvKJxRt9biH7MqnKBwD/RGAt4dEVj32h
nOxB1DeJUX3/tPkhTFg+uLqQA7R64Qw=
=GNIL
-----END PGP SIGNATURE-----

--0jlUeta7muUdJbMT--