Date:   Sat, 27 Nov 2021 15:43:31 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Shayne Chen <shayne.chen@mediatek.com>
Cc:     Felix Fietkau <nbd@nbd.name>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Deren Wu <deren.wu@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] mt76: mt7921: use correct iftype data on 6GHz cap init
Message-ID: <YaJEE0gKhZvtBs6n@lore-desk>
References: <20211126165316.1662-1-shayne.chen@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="zUJr3aSWbgXhvFft"
Content-Disposition: inline
In-Reply-To: <20211126165316.1662-1-shayne.chen@mediatek.com>
Precedence: bulk


--zUJr3aSWbgXhvFft
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Set 6GHz cap to iftype data which is matched to the type of
> current interface.

In this case data points to data[idx] since mt7921 supports just
NL80211_IFTYPE_STATION (please note idx =3D 0 and idx !=3D i).
Anyway this can be an issue in the future when we will add more vif_type.
Maybe we can drop Fixes tag, not sure. Anyway:

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

>=20
> Fixes: 50ac15a511e3 ("mt76: mt7921: add 6GHz support")
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7921/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c b/drivers/n=
et/wireless/mediatek/mt76/mt7921/main.c
> index 5a64126..5540b2d 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
> @@ -178,7 +178,7 @@ mt7921_init_he_caps(struct mt7921_phy *phy, enum nl80=
211_band band,
>  			if (vht_cap->cap & IEEE80211_VHT_CAP_RX_ANTENNA_PATTERN)
>  				cap |=3D IEEE80211_HE_6GHZ_CAP_RX_ANTPAT_CONS;
> =20
> -			data->he_6ghz_capa.capa =3D cpu_to_le16(cap);
> +			data[idx].he_6ghz_capa.capa =3D cpu_to_le16(cap);
>  		}
>  		idx++;
>  	}
> --=20
> 2.25.1
>=20

--zUJr3aSWbgXhvFft
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYaJEEwAKCRA6cBh0uS2t
rOIVAP9Igd1KDjdhJHQHIReTFXMdhNhWSVpGQFZXXzNLDCAFOgD+NVNS9h1ulTfi
LPxg4eCrt+xRDAzpwn5R458JiIuzdwI=
=EMib
-----END PGP SIGNATURE-----

--zUJr3aSWbgXhvFft--