Subject: Re: [PATCH v2] mt76: eeprom: tolerate corrected bit-flips
To:     Daniel Golle <daniel@makrotopia.org>,
        linux-mediatek@lists.infradead.org, linux-wireless@vger.kernel.org
Cc:     Ryder Lee <ryder.lee@mediatek.com>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Felix Fietkau <nbd@nbd.name>
References: <YZ/nv74JH/uQwpBt@makrotopia.org>
From:   Hauke Mehrtens <hauke@hauke-m.de>
Message-ID: <c544231a-4939-4924-ab94-f650c93a66a0@hauke-m.de>
Date:   Sun, 28 Nov 2021 19:34:15 +0100
MIME-Version: 1.0
In-Reply-To: <YZ/nv74JH/uQwpBt@makrotopia.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/25/21 8:45 PM, Daniel Golle wrote:
> mtd_read() returns -EUCLEAN in case of corrected bit-flips.
> As data was read, don't error out in this case.
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>

Acked-by: Hauke Mehrtens <hauke@hauke-m.de>

I tried a similar patch on my device before and it solved the problem too.

> ---
> v2: fix wrong variable name
> 
>   drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c
> index 2d58aa31db934..4a5d14473ddc4 100644
> --- a/drivers/net/wireless/mediatek/mt76/eeprom.c
> +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c
> @@ -65,7 +65,7 @@ int mt76_get_of_eeprom(struct mt76_dev *dev, void *eep, int offset, int len)
>   	offset = be32_to_cpup(list);
>   	ret = mtd_read(mtd, offset, len, &retlen, eep);
>   	put_mtd_device(mtd);
> -	if (ret) {
> +	if (ret && !mtd_is_bitflip(ret)) {
>   		dev_err(dev->dev, "reading EEPROM from mtd %s failed: %i\n",
>   			part, ret);
>   		goto out_put_node;
>