Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 0F5F2C4338F
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Lorenzo Bianconi <lorenzo@kernel.org>
Cc:     sean.wang@mediatek.com, nbd@nbd.name,
        linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com,
        ryder.lee@mediatek.com
Subject: Re: [PATCH wireless-drivers] mt76: fix possible pktid leak
References: <a560caffcc24452fb48af53904bbe5c45ea5db93.1637602268.git.lorenzo@kernel.org>
        <163777451567.4686.3609119971518562275.kvalo@codeaurora.org>
        <YaDo21+/MBeeuTDN@lore-desk> <87fsrj3qxo.fsf@codeaurora.org>
        <YaD8lT5csiLvmBzS@lore-desk> <87sfvij4eh.fsf@codeaurora.org>
        <YaEJ6hQ0uC32+Mts@lore-desk> <YaJAUOkLoQ3mOjcQ@lore-desk>
Date:   Mon, 29 Nov 2021 10:52:04 +0200
In-Reply-To: <YaJAUOkLoQ3mOjcQ@lore-desk> (Lorenzo Bianconi's message of "Sat,
        27 Nov 2021 15:27:28 +0100")
Message-ID: <874k7vgx8r.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Lorenzo Bianconi <lorenzo@kernel.org> writes:

>> > Lorenzo Bianconi <lorenzo@kernel.org> writes:
>> > 
>> > >> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>> > >> 
>> > >> >> Lorenzo Bianconi <lorenzo@kernel.org> wrote:
>> > >> >> 
>> > >> >> > Fix a possible idr pkt-id leak if the packet is dropped on tx side
>> > >> >> > 
>> > >> >> > Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
>> > >> >> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>> > >> >> > Acked-by: Felix Fietkau <nbd@nbd.name>
>> > >> >> 
>> > >> >> Patch applied to wireless-drivers.git, thanks.
>> > >> >> 
>> > >> >> 2a9e9857473b mt76: fix possible pktid leak
>> > >> >
>> > >> > Hi Kalle,
>> > >> >
>> > >> > Unfortunately I found a regression introduced by this patch
>> > >> > for mt7663u (and I
>> > >> > guess for mt7921s as well). Do you want me to post a fix or just a v2?
>> > >> 
>> > >> I don't rebase my trees, so please post a fix. I was planning to submit
>> > >> a pull request to net tree today, but is this so serious that I should
>> > >> skip that?
>> > >
>> > > I have already tested mt7663u but I do not have mt7921s hw for testing (but the
>> > > behaviour should be the same). I guess we can split the patch, just post the
>> > > fix for mt7663u and let Sean the time to test it on mt7921s (I am not sure
>> > > mt7921s is already available on the market). In this way you can send the PR
>> > > today. What do you think?
>> > 
>> > I think it's best to wait, I prefer to have proper build testing on my
>> > tree before I submit the pull request.
>> 
>> ack, fine to me. Let's wait for Sean in this case.
>
> @Sean: if you want to test the code the patch is available here:
> https://github.com/LorenzoBianconi/wireless-drivers/commit/1ffda36c7cbe3a6cfc31868895417d0cd6755306

And if we can't find a quick fix let's just revert 2a9e9857473b. I can't
wait too long.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches