From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Jonas Jelonek <jelonek.jonas@gmail.com>,
        linux-wireless@vger.kernel.org
Cc:     kvalo@codeaurora.org, nbd@nbd.name,
        Jonas Jelonek <jelonek.jonas@gmail.com>,
        Thomas Huehn <thomas.huehn@hs-nordhausen.de>
Subject: Re: [PATCH v2] ath9k: switch to rate table based lookup
In-Reply-To: <20211128090753.958-1-jelonek.jonas@gmail.com>
References: <20211128090753.958-1-jelonek.jonas@gmail.com>
Date:   Mon, 29 Nov 2021 12:46:53 +0100
Message-ID: <87bl239ob6.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jonas Jelonek <jelonek.jonas@gmail.com> writes:

> This patch changes mac80211 rate control for the ath9k driver.
> The rate lookup per packet is changed from legacy usage of
> ieee80211_get_tx_rates() to the new rate table based lookup in struct
> ieee80211_sta->rates.
>
> The most recent rate control API (introduced with
> 0d528d85c519b755b6f4e1bafa3a39984370e1c1) allows drivers to directly get
> rates from ieee80211_sta->rates. This is not used by every driver yet,
> the translation/merge is currently performed in ieee80211_get_tx_rates.
> This patch changes the behaviour and avoids the call to
> ieee80211_get_tx_rates and subsequent calls. ath9k now directly reads
> rates from sta->rates into its rate table. Cause ath9k does not
> expect rate selection in SKB->CB, the table merge does not consider rate
> array in SKB->CB except for the first entry (used for probing).
>
> Tested with a 8devices Rambutan with QCA9558 SoC by performing two
> runs, one without the patch and one with. Generated traffic between
> AP and multiple STAs in each run, measured throughput and captured rc_sta=
ts.
> Comparison of both runs resulted in same rate selection and no
> performance loss or other negative effects.
>
> Co-developed-by: Thomas Huehn <thomas.huehn@hs-nordhausen.de>
> Signed-off-by: Thomas Huehn <thomas.huehn@hs-nordhausen.de>
> Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>

Better, thanks!

Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@redhat.com>