Date:   Mon, 29 Nov 2021 14:32:54 +0100
From:   lorenzo bianconi <lorenzo.bianconi@redhat.com>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>, sean.wang@mediatek.com,
        nbd@nbd.name, linux-wireless@vger.kernel.org,
        ryder.lee@mediatek.com
Subject: Re: [PATCH wireless-drivers] mt76: fix possible pktid leak
Message-ID: <YaTWhgzLaOvr6PjB@lore-desk>
References: <a560caffcc24452fb48af53904bbe5c45ea5db93.1637602268.git.lorenzo@kernel.org>
 <163777451567.4686.3609119971518562275.kvalo@codeaurora.org>
 <YaDo21+/MBeeuTDN@lore-desk>
 <87fsrj3qxo.fsf@codeaurora.org>
 <YaD8lT5csiLvmBzS@lore-desk>
 <87sfvij4eh.fsf@codeaurora.org>
 <YaEJ6hQ0uC32+Mts@lore-desk>
 <YaJAUOkLoQ3mOjcQ@lore-desk>
 <874k7vgx8r.fsf@codeaurora.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="D8qjOYejXFUcOPkb"
Content-Disposition: inline
In-Reply-To: <874k7vgx8r.fsf@codeaurora.org>
Precedence: bulk


--D8qjOYejXFUcOPkb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>=20
> >> > Lorenzo Bianconi <lorenzo@kernel.org> writes:
> >> >=20
> >> > >> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> >> > >>=20
> >> > >> >> Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> >> > >> >>=20
> >> > >> >> > Fix a possible idr pkt-id leak if the packet is dropped on t=
x side
> >> > >> >> >=20
> >> > >> >> > Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
> >> > >> >> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> >> > >> >> > Acked-by: Felix Fietkau <nbd@nbd.name>
> >> > >> >>=20
> >> > >> >> Patch applied to wireless-drivers.git, thanks.
> >> > >> >>=20
> >> > >> >> 2a9e9857473b mt76: fix possible pktid leak
> >> > >> >
> >> > >> > Hi Kalle,
> >> > >> >
> >> > >> > Unfortunately I found a regression introduced by this patch
> >> > >> > for mt7663u (and I
> >> > >> > guess for mt7921s as well). Do you want me to post a fix or jus=
t a v2?
> >> > >>=20
> >> > >> I don't rebase my trees, so please post a fix. I was planning to =
submit
> >> > >> a pull request to net tree today, but is this so serious that I s=
hould
> >> > >> skip that?
> >> > >
> >> > > I have already tested mt7663u but I do not have mt7921s hw for tes=
ting (but the
> >> > > behaviour should be the same). I guess we can split the patch, jus=
t post the
> >> > > fix for mt7663u and let Sean the time to test it on mt7921s (I am =
not sure
> >> > > mt7921s is already available on the market). In this way you can s=
end the PR
> >> > > today. What do you think?
> >> >=20
> >> > I think it's best to wait, I prefer to have proper build testing on =
my
> >> > tree before I submit the pull request.
> >>=20
> >> ack, fine to me. Let's wait for Sean in this case.
> >
> > @Sean: if you want to test the code the patch is available here:
> > https://github.com/LorenzoBianconi/wireless-drivers/commit/1ffda36c7cbe=
3a6cfc31868895417d0cd6755306
>=20
> And if we can't find a quick fix let's just revert 2a9e9857473b. I can't
> wait too long.

ack, Deren verified the fix. I will post it now.

Regards,
Lorenzo

>=20
> --=20
> https://patchwork.kernel.org/project/linux-wireless/list/
>=20
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa=
tches
>=20

--D8qjOYejXFUcOPkb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYaTWhgAKCRA6cBh0uS2t
rOSKAP9nqRN1ixJ6YG2t06EZ90Xm1xiSqz2Y+l3wB7DYpm4HfAEAsylhYX6Bg4VG
npzp6y3CK2F87mzDE7dfg2JkeQrBQg8=
=5+Hz
-----END PGP SIGNATURE-----

--D8qjOYejXFUcOPkb--