Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org AB28BC4338F
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] ath11k: Avoid NULL ptr access during mgmt tx cleanup
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <1637832614-13831-1-git-send-email-quic_srirrama@quicinc.com>
References: <1637832614-13831-1-git-send-email-quic_srirrama@quicinc.com>
To:     Sriram R <quic_srirrama@quicinc.com>
Cc:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        Sriram R <quic_srirrama@quicinc.com>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <163820080368.7221.13211393859054966547.kvalo@codeaurora.org>
Date:   Mon, 29 Nov 2021 15:46:47 +0000 (UTC)
Precedence: bulk

Sriram R <quic_srirrama@quicinc.com> wrote:

> Currently 'ar' reference is not added in skb_cb during
> WMI mgmt tx. Though this is generally not used during tx completion
> callbacks, on interface removal the remaining idr cleanup callback
> uses the ar ptr from skb_cb from mgmt txmgmt_idr. Hence
> fill them during tx call for proper usage.
> 
> Also free the skb which is missing currently in these
> callbacks.
> 
> Crash_info:
> 
> [19282.489476] Unable to handle kernel NULL pointer dereference at virtual address 00000000
> [19282.489515] pgd = 91eb8000
> [19282.496702] [00000000] *pgd=00000000
> [19282.502524] Internal error: Oops: 5 [#1] PREEMPT SMP ARM
> [19282.783728] PC is at ath11k_mac_vif_txmgmt_idr_remove+0x28/0xd8 [ath11k]
> [19282.789170] LR is at idr_for_each+0xa0/0xc8
> 
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-00729-QCAHKSWPL_SILICONZ-3 v2
> Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

a93789ae541c ath11k: Avoid NULL ptr access during mgmt tx cleanup

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1637832614-13831-1-git-send-email-quic_srirrama@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches