Date:   Tue, 30 Nov 2021 12:07:34 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [bug report] iwlwifi: integrate with iwlmei
Message-ID: <20211130090734.GV18178@kadam>
References: <20211130062017.GA20271@kili>
 <SA1PR11MB58251D5736428C2C0FE235E4F2679@SA1PR11MB5825.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <SA1PR11MB58251D5736428C2C0FE235E4F2679@SA1PR11MB5825.namprd11.prod.outlook.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uAVOhnwyfIYpmE8JAa+GJLxfqzZixbDpo6nFnyejHexFDVqqVUPOIvhSl8hT?=
 =?us-ascii?Q?S54iu3cKwPSiCwrmBrvMW6MKECZjRadIO/N2J8qE9ONPVPDLXTQ4hggywMFL?=
 =?us-ascii?Q?MNgeZ0AKQ+VTQL3FLhm+uYU4+ETLRRxS8DpHahhZZRTANPddD6ujnCMxNwE4?=
 =?us-ascii?Q?C+Bogh9eQ5j85gp00f5ubepiVfJEdW+WyVAgZNtw5KgEMV8ZrHglr0LwoPRU?=
 =?us-ascii?Q?W9n16XSliZ9oOTZ5HsuGFr6qQvXmqLMof+mQxQVQhaxQaz2/7bmJbN8z+zrZ?=
 =?us-ascii?Q?jXq1VGFDKyqpemB8DwAhlM/wNMXA044/jNX+BLgT/ZXqJv689Q3RSITmq88p?=
 =?us-ascii?Q?86e5rLLlBBawwz1G1P9oSIEKZFeInPwtW6Uhi4wwweJzX86Lc5N6S79iwgYb?=
 =?us-ascii?Q?jEixgGohrPxQl/ydl5CtmwZNUh+Id96RXYpmydGhKJmKzVEhq9Iox+VNNDID?=
 =?us-ascii?Q?G3bZvh2rXgOUklnc4rcU9XCh0ig2ZYKIypWCVvq+94RW3Azpxq3NjReDGJX5?=
 =?us-ascii?Q?yjnIvYCd6WCjVuYYAczHpUNEHFDsCe6aFhYh4f7SE29RtHPK+q4neWSQvO4u?=
 =?us-ascii?Q?pDx26w6vSO9kXiDCZmexu8cZOaDtw0Lo3bgYQOlPNJyzVT/Ig4aKRamejPhk?=
 =?us-ascii?Q?FNVPFGAzBp1sMHAF+OM7zSE3OXGmtAy9owGCoN98N9jbd+lhzK90k/ZEEMuq?=
 =?us-ascii?Q?+Hrn4n3TJefp+F0xnUAWeLwP97DM8/TqWN42Z+h2RM3lalqdnWlGAM0SxRmg?=
 =?us-ascii?Q?Q31MZllsuqCt3YKE3Jhud+hKJMKomKykvD4aVL34o43y6HxpeBXXvDfra1Oi?=
 =?us-ascii?Q?hggZUHZS/wkffNXRKs4ct8Ac3EKTKEDozNw3y5pJvU73rleS93C/1tGuEaQg?=
 =?us-ascii?Q?uJskXEF17+qm4gERmH7SNQRwavqn9U0LQnMAQ/cwtVm2IXMufWROjnOQQgvo?=
 =?us-ascii?Q?F0D6oE4eWlAxQRDgTBFggl9eTKxWkjAp1jF57Fv3ApWgXTGxxGC1m+yJh6j5?=
 =?us-ascii?Q?r88DKnF7yfEQHOFQfUbRrA6cAIBtDia8mbnPec116w9OibqZ6De0J9S3w1Se?=
 =?us-ascii?Q?NoXpMBGLRQZvOnTM/HiwJysJrvS7l+bFJ4qWZuSYYmydWwb1ujiOmqGbjXl0?=
 =?us-ascii?Q?41xBYCAv5JVA+en30qwhV36OBjeYPvCTLZXtlJ+EqWdcOO/ty+bu13oLM6s0?=
 =?us-ascii?Q?MgC3wyX0RP2pg481J6mcRJzSd169s18AfsvYKVoX5i3GxRhgT7bt1KmRZ4Cn?=
 =?us-ascii?Q?x99pvMkrAIywSKYASvFr+Elo8fa6Ct7sfzCV+wIsB/hLc+M0dMUVZcZ8oEgG?=
 =?us-ascii?Q?zq05dcgIRogOC+wjcx2AslSLKolASXz5MucXNcnWD6bMoY2ORmbTl6wlnFNk?=
 =?us-ascii?Q?vmHmkgIDF++ntYF0qffnlQxa8e0TZMu/RY6Bf/cxsjYnbWPHjmDIOWVaygwH?=
 =?us-ascii?Q?6r3YHjEILZfn+2olTpHnljTISh6UDMwsW+GYTfpjSvLLMuS8f+9eTsuulTgr?=
 =?us-ascii?Q?ZP7BoZOtD23aWgJHcqfKKFIrUbW/XRnMJd3r0BvvrFxIp79GzJYK4w+fnTto?=
 =?us-ascii?Q?Q9iaDHuoxN9Pg2Cq+0oFIqSJT+v+/SFQxiywPwcaCTK8B5Z2E68keB2Abszb?=
 =?us-ascii?Q?cCBaotSnhoNNuqdl/ReTG8Qa1z2E6f+0wiv0fYMmHEeG1Wfu9zcGYXZ3aMtL?=
 =?us-ascii?Q?xQ4echZpmuJtcvm8pbzGCs2o94k=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b2327b7-39d4-47ed-dfbc-08d9b3e0e3d2
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2021 09:07:52.7598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D0DE+z0hqVVQoERHrnj01TjG4cSX1HiGxFxWICDfz5JVCUxcVC0ZuhkK9zds0ZWuZbohzmo7v/Ed/AOS+tXvzKjSzrofYqURTR/pi2RzniE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2400
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10183 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111300052
X-Proofpoint-GUID: 7nvO4yheaWCD60kAF72Zn-GWaPxn-_mF
X-Proofpoint-ORIG-GUID: 7nvO4yheaWCD60kAF72Zn-GWaPxn-_mF
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Tue, Nov 30, 2021 at 08:09:48AM +0000, Grumbach, Emmanuel wrote:
> Hi Dan,
> 
> > Hello Emmanuel Grumbach,
> > 
> > The patch 6d19a5eba5cd: "iwlwifi: integrate with iwlmei" from Nov 12, 2021,
> > leads to the following Smatch static checker warning:
> > 
> > 	drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:2640
> > iwl_mvm_start_ap_ibss()
> > 	error: NULL dereference inside function
> > '__iwl_mvm_mac_set_key()'
> 
> Where in __iwl_mvm_mac_set_key() ?
> This function should be able to cope with with a NULL sta I think.
> I don't really see how this could be related to my patch since iwlmei is not related to AP mode at all.
> 
> I also moved to that commit, but the line numbers don't match, so I am a bit confused.
> 

I'm on yesterday's linux-next.  The patch moves the mvmsta assignment to
the start of the function.

	mvmsta = iwl_mvm_sta_from_mac80211(sta);
                                           ^^^^

It introduces a couple other Smatch warnings as well.

drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:3643 __iwl_mvm_mac_set_key() warn: variable dereferenced before check 'sta' (see line 3594)
drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:3773 __iwl_mvm_mac_set_key() warn: variable dereferenced before check 'sta' (see line 3594)

regards,
dan carpenter