Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\))
Subject: Re: [PATCH v5] nl80211: reset regdom when reloading regdb
From:   Finn Behrens <me@kloenk.dev>
In-Reply-To: <YaZLEEj2pUU/DhZD@archlinux-ax161>
Date:   Tue, 30 Nov 2021 17:50:58 +0100
Cc:     Finn Lasse Behrens <me@kloenk.dev>, johannes@sipsolutions.net,
        linux-wireless@vger.kernel.org, llvm@lists.linux.dev
Content-Transfer-Encoding: quoted-printable
Message-Id: <6BAD2771-7C01-408E-98BE-76A1CAF3A810@kloenk.dev>
References: <20210526112418.cdwkn7ed4twctimc@imap.mailbox.org>
 <YaIIZfxHgqc/UTA7@gimli.kloenk.dev> <YaZLEEj2pUU/DhZD@archlinux-ax161>
To:     Nathan Chancellor <nathan@kernel.org>
Precedence: bulk


> On 30. Nov 2021, at 17:02, Nathan Chancellor <nathan@kernel.org> =
wrote:
>=20
> Hi Finn,
>=20
> On Sat, Nov 27, 2021 at 11:28:53AM +0100, Finn Behrens wrote:
>> this reloads the regdom when the regulatory db is reloaded.
>> Without this patch the user had to change the regulatoy domain to a
>> different, and then reset it to the one the user is in, to have the =
new
>> regulatory db take effect
>>=20
>> Signed-off-by: Finn Behrens <fin@nyantec.com>
>=20
> This patch as commit 1eda919126b4 ("nl80211: reset regdom when =
reloading
> regdb") in -next causes the following clang warning/error:
>=20
> net/wireless/reg.c:1137:23: error: implicit conversion from =
enumeration type 'enum nl80211_user_reg_hint_type' to different =
enumeration type 'enum nl80211_reg_initiator' =
[-Werror,-Wenum-conversion]
>        request->initiator =3D NL80211_USER_REG_HINT_USER;
>                           ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
>=20
> Should that be NL80211_REGDOM_SET_BY_CORE (same value, 0) or something
> different?
>=20
> Cheers,
> Nathan

Hi Nathan,

I think It should have been NL80211_REGDOM_SET_BY_USER, as the reload =
flag check is currently implemented in the user hint function. But If I =
see it correctly right now. We could remove the reload flag,
and NL80211_REGDOM_SET_BY_CORE should work as well. As the =
reg_query_database function is called unconditionally there.

I will prepare a patch that reverts the reload flag, and changes to =
NL80211_REGDOM_SET_BY_CORE as this already works. Or should it be =
NL80211_REGDOM_SET_BY_USER, as it=E2=80=99s results from an user
called function?

Cheers,
Finn=