Message-ID: <6999d2e5-a2c5-0247-83c3-f27a0fae157e@nbd.name>
Date:   Wed, 1 Dec 2021 13:40:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v3 08/11] mt76: mt7915: update rx rate reporting for
 mt7916
Content-Language: en-US
To:     Bo Jiao <bo.jiao@mediatek.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Xing Song <xing.song@mediatek.com>,
        Sujuan Chen <sujuan.chen@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>
References: <cover.1637652742.git.Bo.Jiao@mediatek.com>
 <c3519b5f2ed307b18bd0c23e3185ee5d894aa5ca.1637652742.git.Bo.Jiao@mediatek.com>
From:   Felix Fietkau <nbd@nbd.name>
In-Reply-To: <c3519b5f2ed307b18bd0c23e3185ee5d894aa5ca.1637652742.git.Bo.Jiao@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021-11-23 08:49, Bo Jiao wrote:
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> index 057ab27..0650140 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> @@ -969,11 +969,14 @@ static void mt7915_sta_statistics(struct ieee80211_hw *hw,
>   	struct mt7915_phy *phy = mt7915_hw_phy(hw);
>   	struct mt7915_sta *msta = (struct mt7915_sta *)sta->drv_priv;
>   	struct rate_info *txrate = &msta->wcid.rate;
> -	struct rate_info rxrate = {};
>   
> -	if (!mt7915_mcu_get_rx_rate(phy, vif, sta, &rxrate)) {
> -		sinfo->rxrate = rxrate;
> -		sinfo->filled |= BIT_ULL(NL80211_STA_INFO_RX_BITRATE);
> +	if (is_mt7915(&phy->dev->mt76)) {
> +		struct rate_info rxrate = {};
> +
> +		if (!mt7915_mcu_get_rx_rate(phy, vif, sta, &rxrate)) {
> +			sinfo->rxrate = rxrate;
> +			sinfo->filled |= BIT_ULL(NL80211_STA_INFO_RX_BITRATE);
> +		}
>   	}
>   
>   	if (!txrate->legacy && !txrate->flags)

You can simplify this part by leaving the code as-is and only changing 
the if condition like this:

if (is_mt7915(&phy->dev->mt76) &&
     !mt7915_mcu_get_rx_rate(phy, vif, sta, &rxrate) {
	...
}