From:   Aditya Garg <gargaditya08@live.com>
To:     Hector Martin <marcan@marcan.st>
CC:     "aspriel@gmail.com" <aspriel@gmail.com>,
        "franky.lin@broadcom.com" <franky.lin@broadcom.com>,
        "hante.meuleman@broadcom.com" <hante.meuleman@broadcom.com>,
        "chi-hsien.lin@infineon.com" <chi-hsien.lin@infineon.com>,
        "wright.feng@infineon.com" <wright.feng@infineon.com>,
        "chung-hsien.hsu@infineon.com" <chung-hsien.hsu@infineon.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "brcm80211-dev-list.pdl@broadcom.com" 
        <brcm80211-dev-list.pdl@broadcom.com>,
        "SHA-cyfmac-dev-list@infineon.com" <SHA-cyfmac-dev-list@infineon.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Stan Skowronek <stan@corellium.com>,
        Sven Peter <sven@svenpeter.dev>,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Joey Gouly <joey.gouly@arm.com>
Subject: Re: [PATCH v3 1/3] brcmfmac: Add support for BCM4378 on Apple
 hardware (with their special OTP).
Thread-Topic: [PATCH v3 1/3] brcmfmac: Add support for BCM4378 on Apple
 hardware (with their special OTP).
Thread-Index: AQHX0GuU60Mzr7gPW0qK2qCd4kZ7oKvxeKSAgC8IL4A=
Date:   Fri, 3 Dec 2021 06:41:44 +0000
Message-ID: <510D7CA0-8DED-488B-9F27-1F407F74861C@live.com>
References: <PNZPR01MB4415874CD530F2C305872F88B88A9@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
 <PNZPR01MB44155DC40EAA3A13FCE85193B88A9@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
 <PNZPR01MB44156C94263746D4EC592E96B88B9@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
 <391FADA9-4C9D-42F5-97FA-B87D36BE901B@live.com>
 <4928ea79-2794-05fb-d1a8-942b589a1c3a@marcan.st>
In-Reply-To: <4928ea79-2794-05fb-d1a8-942b589a1c3a@marcan.st>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:  [CGeXRie244E5p95IStUVel203jRJZQsUeNBP+6XfMw9Vx8NuOXzVP4VzRKdwUbjm]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3c4ffadb-0fde-4376-3c7e-08d9b627f8f5
x-ms-traffictypediagnostic: PNZPR01MB4414:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ddOdaFaOiMbn8NXk43d2dI/e90aXPLQHUvvSjXmFCbDGugalkPbQ71TfikksZCDqljGu4PIOL3w2v8w7t25a19YSoSXsLNlNrDAQMw7ku6t2v+xt2jwHpOmMu+6jaHN50ZzdrJYY0ncCUHB8oh2MY4Abi54oExf0EUG1O5+1q5LOSpy2twG6I4tXh1J5qslmJ28CXTO1yAaEq66gmXXDy3JOupwVv+YVS4jkYzEc5BOkWonKgOTE4lNEEXoRiqJu5S1uFqKQDeoDyaaFXbH5FaGSisykD/zpa/0CFy/v1dekuW31CgpTpD1F6klbt1vp57GTDOmTL7WPtpv9VYFTcDfuzuYVTpzbHady7xngSKy8ary3wuDMVQMLgaRMb9/9DR7P3IPzg5tor4ax1kS/eKp3xxBZR8IekW3GwrN67fDUBu5bpYqAIx8uW4Ndn1n6R9SjcJxhHilxJ/3Lz1G6GEIwypjG42tG/EVn3Y+GfVx1Jxi8Zykftj5yGs2GnxFJ6qSxj22A9KSPu39+2Y6TLfGwCxuayhopwDMsKnUR69s2jT7UvW9ay6WiKep3TbNTIfRwh1raq0a98vRjV0Ev3lpvNE7FnI9DjqpAxBGuq7SU2m0A3aEITO8QIIFJ+P21
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VFqgMf9NdiZHaDXQqCTxtHs7jjkBEBjBXxcP6ka9sMlkBf/MMN2cQHCS1NDi?=
 =?us-ascii?Q?2N3ZSvyiUrRusRJdFdsl58GmxpyBcvzXH+LSbxWFMIwbPDP5QotDET9FGTpI?=
 =?us-ascii?Q?C/RB9u/CBDN4YiJf+wXCKuO/Gla5u/FSS3a2fb63Tf7G+cQpGGAG1oo/P/aj?=
 =?us-ascii?Q?JCSUjA0815hvT0pxLXRVkq5aX97QFxpOKjTaewHscQO1bhYcBxGVBGjdgroz?=
 =?us-ascii?Q?e4CheCZ+S4h3GGVXuzUX8onELcv8fn9YZuOJRCP9AWcISPe+EJHw6s93hFjN?=
 =?us-ascii?Q?9sQE2Uu6dgzwgGnbbTRXtfdAvjXhO2ZFr4OjxSikPySurOIG2Df2HyyVQARM?=
 =?us-ascii?Q?kyIQK+zut1YekmQGyerQhve9lHonkB3wIre5FKDpRu4x6Ze0d1fDZM0ZibEk?=
 =?us-ascii?Q?jlFkQSKLhrR5MWtW4l/VR9KEdv/c88tSqJA8Od5FKuAFcI88smm7j8XLeWof?=
 =?us-ascii?Q?cPIQ0jv6qNrk2Tg2hHpvUNwMLgWmJsitp2QEg04f6NckxRMxpjgPLI5v7VCy?=
 =?us-ascii?Q?1zG/V1RNE5aFPmtQhpHbFMRItdWRcCZ5pVYfSK9vEvfLxE1y4BO/8pVuJJSJ?=
 =?us-ascii?Q?iUzi5kd8ChS4cwQvzBqVu622z1nBo4eHgTeAidFo3DCqd8dq95OGPfFlehCJ?=
 =?us-ascii?Q?qwGtUmtlr4RvN7c0WLtgaLr1FXl28orEC1p56RvuzKDKoaKVTUZnfDRy4FA5?=
 =?us-ascii?Q?gfCOezMOH3LzMaBiRD6IdOUMINtMmr8t2ruh+7mamJFlB4u6HKvNeeoY3pGk?=
 =?us-ascii?Q?V2ck3HRQYU5c7Db74n4rI99JYOQ37RcA8Fow22GeMDR+Anrd5t+0abc7dgri?=
 =?us-ascii?Q?me4mNowj6UYTgC5r0uZTy5ymzB698chUwj/QtEstfEkPxV1cdOBIj/fcsxCY?=
 =?us-ascii?Q?ymWV/43ftFMJia0djYQl1KHjBIqkQEURz9k+C41o9qkxdRcReyHccgMRc12Q?=
 =?us-ascii?Q?T0h4tYu5k6H/cReH5FSvncVgVjvWjZxEzbQaE9m1u47BL2QhO29ZBrchAQGY?=
 =?us-ascii?Q?kBBE8ruwyQ9F52JGexUUmbm4IQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C1DEC40790465747B3D1641688B20818@INDPRD01.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-42ed3.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c4ffadb-0fde-4376-3c7e-08d9b627f8f5
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2021 06:41:44.6078
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNZPR01MB4414
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


> On 03-Nov-2021, at 1:58 PM, Hector Martin <marcan@marcan.st> wrote:
>=20
> Hi,
>=20
> I'd been meaning to rewrite this patch because it's such a mess, but sinc=
e we're here... (CCing some relevant folks)
>=20
> Overall: this patch combines a ton of unrelated random changes, many of w=
hich without explanation, with some completely crazy approaches. Stan (CC'e=
d) has so far refused to interact with the kernel community in any way what=
soever, and I do not feel comfortable using his patches without thorough re=
view, including reverse engineering the changes to figure out what they act=
ually do and why. We've already gone through this with some of his other pa=
tches, which ended up being largely rewritten or entirely dropped in the en=
d.
>=20
> The firmware situation with this patch is completely unacceptable. It see=
ms the original intent here is to have users load the driver, have it print=
 the required firmware version, and then expect users to copy specifically =
that firmware file set from macOS, and reload again. This is obviously not =
the right way to do this. We need to statically copy all firmware from macO=
S/recovery mode with a naming scheme that this driver can use, at initial i=
nstall time, and it needs to dynamically select the right firmware for any =
given platform it is booted on.
>=20
> The main issue with these machines is that there is a large set of requir=
ed firmware variants; a few core firmware files plus many nvram variants fo=
r different hardware modules and device revisions. A lot of them are identi=
cal and can be symlinked, but we need to work out a naming scheme for these=
 variations. There are several more dimensions of nvram selection than what=
 we're used to on Linux.
Update on the firmware situation :-
Thanks to this commit (https://git.kernel.org/pub/scm/linux/kernel/git/torv=
alds/linux.git/commit/drivers/net/wireless/broadcom/brcm80211/brcmfmac?h=3D=
v5.16-rc3&id=3D5ff013914c62c493c206d70554cfb1d311ea481a), we can have model=
 specific .bin files for Macs.
Example :- brcmfmac4364-pcie.Apple Inc.-MacBookPro16,1.bin is the file spec=
ific to MacBook Pro 16 inch, 2019

We would need something like this for the .clm_blob files, that is we would=
 want additional support for per board suffix clm_blob files. This should s=
olve the firmware problem for .bin and .clm_blob files. A patch to get the =
same feature would be appreciated. I am Ccing the original author of the ab=
ove commit too.

Next we have is the .txt NVRAM file. This seems tricky cause I haven't been=
 able to find a way to get the module version, on which the variants depend=
 on.