Message-ID: <a59667158ce8499ae2d256dfcd34f20fe1307bdd.camel@sipsolutions.net>
Subject: Re: [PATCH] mac80211: disable BSS color collision detection in case
 of no free colors
From:   Johannes Berg <johannes@sipsolutions.net>
To:     "Rameshkumar Sundaram (QUIC)" <quic_ramess@quicinc.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Lavanya Suresh <lavaks@codeaurora.org>
Date:   Fri, 03 Dec 2021 12:48:04 +0100
In-Reply-To: <DM6PR02MB49375D43B73E14EC6B0E5754E96A9@DM6PR02MB4937.namprd02.prod.outlook.com>
References: <1638506507-21139-1-git-send-email-quic_ramess@quicinc.com>
         <3a4fc4398a5dfe03933de8d695a8b605d700a94b.camel@sipsolutions.net>
         <DM6PR02MB49375D43B73E14EC6B0E5754E96A9@DM6PR02MB4937.namprd02.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 (3.42.1-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 2021-12-03 at 11:42 +0000, Rameshkumar Sundaram (QUIC) wrote:
> > > 
> > 
> > I'm not sure I like this mechanism - in ieee80211_start_ap() we
> > explicitly take
> > it from the parameters given via nl80211, so it feels the same
> > should be true
> > here. Why isn't it done that way?
> 
> This is because in this case only beacon will change and in
> nl80211_set_beacon()
> we don’t parse NL80211_ATTR_HE_BSS_COLOR attribute or do
> nl80211_calculate_ap_params()
> 

Yeah but we could change that? Why not?

johannes