Subject: Re: [PATCH 04/11] mt76: mt7915: use nss for calculating rx-chains
To:     Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
References: <20211118164056.2965-1-greearb@candelatech.com>
 <20211118164056.2965-4-greearb@candelatech.com>
 <fc14e235-efce-514b-4f7e-8d83613eaffa@nbd.name>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
Message-ID: <9449a4f6-fc86-23ef-0492-efa624093e41@candelatech.com>
Date:   Fri, 3 Dec 2021 07:33:08 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <fc14e235-efce-514b-4f7e-8d83613eaffa@nbd.name>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-MW
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/3/21 1:16 AM, Felix Fietkau wrote:
> On 2021-11-18 17:40, greearb@candelatech.com wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> When group-5 is enabled, we can find the actuall NSS used.
>> In that case, update the rx chains info so that the upper
>> stack can give better idea of actual antenna usage.
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
> I'm not sure this is correct. From my understanding, nss does not determine which antennas (and how many of them) are involved in receiving the signal.
> 
> - Felix
> 

I guess this would take some special knowledge of this chip and how firmware reports
the descriptor to know for sure.

Ath10k at least acts similar to how I wrote this patch....

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com