Date:   Fri, 3 Dec 2021 18:27:52 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     sean.wang@mediatek.com
Cc:     nbd@nbd.name, sven@narfation.org, jf@simonwunderlich.de,
        linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: mt76: MT7921K monitor mode not working
Message-ID: <YapTmM3EztojTS9F@lore-desk>
References: <YapBMGjLcjuBo/vw@lore-desk--annotate>
 <1638551402-3864-1-git-send-email-sean.wang@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="2d1Hv3ATuhUm5puw"
Content-Disposition: inline
In-Reply-To: <1638551402-3864-1-git-send-email-sean.wang@mediatek.com>
Precedence: bulk


--2d1Hv3ATuhUm5puw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> From: Sean Wang <sean.wang@mediatek.com>
>=20
> >> On Thursday, 2 December 2021 23:13:31 CET Lorenzo Bianconi wrote:
> >> > IIRC you need to disable runtime-pm and deep-sleep to proper enable
> >> > monitor
> >> > mode:
> >> >
> >> > echo 0 > /sys/kernel/debug/ieee80211/phy<x>/mt76/runtime-pm
> >> > echo 0 > /sys/kernel/debug/ieee80211/phy<x>/mt76/deep-sleep
> >> >
> >> > Can you please give it whirl?
> >>
> >> Jan gave me the card. I've set it to a rather busy channel (2.4GHz
> >> channel 11), created a monitor interface, attached tcpdump and then
> >> waited what happens. I didn't get anything and then I've tried to set
> >> runtime-pm and deep- sleep to 0. This didn't change the behavior for
> >> me at lot. I saw two packets and then it went silent again.
> >>
> >> I wanted to try the same on a different card (ath11k) in the same
> >> system. But it crashed my complete system - so I had to recreate the
> >> test setup. This time, I've set runtime-pm + deep-sleep to 0 before
> >> creating mon0. After doing this, it seemed to work.
> >
> >interesting, adding Sean to the loop here.
> >It seems the fw is mainting a different state in this case.
>=20
> fw cannot receive any frame on monitor mode in deeply doze mode
>=20
> so it seemed to me we need a patch to explicitly disable pm runtime in dr=
iver when monitor interface is enabled until it is being disabled.

ack, I agree, but I guess the point here is what is the difference (from th=
e fw pov) if you disable
runtime-pm/deep-sleep before/after the vif is added. I guess it is supposed=
 to
be the same, right?

Regards,
Lorenzo

>=20
> >
> >@Sean: any pointers?
> >
> >Regards,
> >Lorenzo
> >
> >>
> >> Kind regards,
> >>	Sven
> >
>=20

--2d1Hv3ATuhUm5puw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYapTmAAKCRA6cBh0uS2t
rCiaAQDynMHJ4nmPLYaB2HHROmr2j3LJ0hZZVGq8xkq2pxcJSgD/bA94FR3SBt35
vdNr/NkAQiEihVIh5n00nvpWgMypBQA=
=YHOk
-----END PGP SIGNATURE-----

--2d1Hv3ATuhUm5puw--