Subject: Re: [PATCH] mt76: mt7915: add mu-mimo and ofdma debugfs knobs
To:     MeiChia Chiu <MeiChia.Chiu@mediatek.com>,
        Felix Fietkau <nbd@nbd.name>
Cc:     Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Money Wang <Money.Wang@mediatek.com>,
        linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org
References: <20211206141006.29632-1-MeiChia.Chiu@mediatek.com>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
Message-ID: <7158a937-57f3-2bd8-591e-124a18d2d8e8@candelatech.com>
Date:   Mon, 6 Dec 2021 08:43:36 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20211206141006.29632-1-MeiChia.Chiu@mediatek.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-MW
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/6/21 6:10 AM, MeiChia Chiu wrote:
> From: MeiChia Chiu <meichia.chiu@mediatek.com>
> 
> Add mu-mimo and ofdma packet counters statistics.

Hello,

Are these stats clear-on-read in the firmware?  If so, then we need to accumulate
them in the driver.

Is there any significant downside to enabling the stats?  For instance, a performance
degradation in the firmware/hardware?

Thanks,
Ben

> 
> Reviewed-by: Money Wang <money.wang@mediatek.com>
> Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
> Signed-off-by: MeiChia Chiu <meichia.chiu@mediatek.com>
> ---
>   .../net/wireless/mediatek/mt76/mt7915/debugfs.c | 242 ++++++++++++++++++++++++++++++++++++++++++++++-
>   .../net/wireless/mediatek/mt76/mt7915/mcu.c     |  41 ++++++++
>   .../net/wireless/mediatek/mt76/mt7915/mcu.h     |  45 +++++++++
>   .../net/wireless/mediatek/mt76/mt7915/mt7915.h  |   3 +
>   4 files changed, 330 insertions(+), 1 deletion(-)
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com