Message-ID: <72ca4f5fe3c351ec56dee4935b28c7b7f26188c2.camel@mediatek.com>
Subject: Re: [PATCH] mt76: mt7915: add mu-mimo and ofdma debugfs knobs
From:   meichia chiu <meichia.chiu@mediatek.com>
To:     Ben Greear <greearb@candelatech.com>, Felix Fietkau <nbd@nbd.name>
CC:     Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        "Ryder Lee" <ryder.lee@mediatek.com>,
        Money Wang <Money.Wang@mediatek.com>,
        <linux-wireless@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>
Date:   Tue, 7 Dec 2021 15:25:48 +0800
In-Reply-To: <7158a937-57f3-2bd8-591e-124a18d2d8e8@candelatech.com>
References: <20211206141006.29632-1-MeiChia.Chiu@mediatek.com>
         <7158a937-57f3-2bd8-591e-124a18d2d8e8@candelatech.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-12-06 at 08:43 -0800, Ben Greear wrote:
> On 12/6/21 6:10 AM, MeiChia Chiu wrote:
> > From: MeiChia Chiu <meichia.chiu@mediatek.com>
> > 
> > Add mu-mimo and ofdma packet counters statistics.
> 
> Hello,
> 
> Are these stats clear-on-read in the firmware?  If so, then we need
> to accumulate
> them in the driver.
> 
> Is there any significant downside to enabling the stats?  For
> instance, a performance
> degradation in the firmware/hardware?
> 
> Thanks,
> Ben

Hi Ben,

Yes, the current design is clear-on-read and its sole purpose is for
debugging only. If you need statistics, this may have to be done in
another way.

Yes, a performance degradation is expected since enabling this debug
function would burden MCU with more calculation.

Thanks,
Meichia