Date:   Tue, 7 Dec 2021 14:04:31 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Ricardo Martinez <ricardo.martinez@linux.intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Matt Wagantall <mattw@codeaurora.org>,
        Mitchel Humpherys <mitchelh@codeaurora.org>
Cc:     netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
        kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net,
        ryazanov.s.a@gmail.com, loic.poulain@linaro.org,
        m.chetan.kumar@intel.com, chandrashekar.devegowda@intel.com,
        linuxwwan@intel.com, chiranjeevi.rapolu@linux.intel.com,
        haijun.liu@mediatek.com, amir.hanania@intel.com,
        dinesh.sharma@intel.com, eliot.lee@intel.com,
        mika.westerberg@linux.intel.com, moises.veleta@intel.com,
        pierre-louis.bossart@intel.com, muralidharan.sethuraman@intel.com,
        Soumya.Prakash.Mishra@intel.com, sreehari.kancharla@intel.com,
        suresh.nagaraj@intel.com
Subject: Re: [PATCH net-next v3 06/12] net: wwan: t7xx: Data path HW layer
Message-ID: <Ya9Nz8U+i3r56H5h@smile.fi.intel.com>
References: <20211207024711.2765-1-ricardo.martinez@linux.intel.com>
 <20211207024711.2765-7-ricardo.martinez@linux.intel.com>
 <Ya9MlTpZ8Var/JMy@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ya9MlTpZ8Var/JMy@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

+Cc: people from "[PATCH v7 1/2] iopoll: Introduce memory-mapped IO polling macros"

Any idea why ioreadXX() doomed between v7 and v10 of that series?
Any further work is going on?

On Tue, Dec 07, 2021 at 01:59:18PM +0200, Andy Shevchenko wrote:
> On Mon, Dec 06, 2021 at 07:47:05PM -0700, Ricardo Martinez wrote:
> > From: Haijun Liu <haijun.liu@mediatek.com>
> > 
> > Data Path Modem AP Interface (DPMAIF) HW layer provides HW abstraction
> > for the upper layer (DPMAIF HIF). It implements functions to do the HW
> > configuration, TX/RX control and interrupt handling.
> 
> ...
> 
> > +	ret = readx_poll_timeout_atomic(ioread32, hw_info->pcie_base + DPMAIF_AO_UL_AP_L2TIMR0,
> > +					value, (value & ul_intr_enable) != ul_intr_enable, 0,
> > +					DPMAIF_CHECK_INIT_TIMEOUT_US);
> > +	if (ret)
> > +		return ret;
> 
> ...
> 
> > +	ret = readx_poll_timeout_atomic(ioread32, hw_info->pcie_base + DPMAIF_AO_UL_APDL_L2TIMR0,
> > +					value, (value & ul_intr_enable) != ul_intr_enable, 0,
> > +					DPMAIF_CHECK_INIT_TIMEOUT_US);
> > +	if (ret)
> > +		return ret;
> 
> ...
> 
> > +	ret = readx_poll_timeout_atomic(ioread32, hw_info->pcie_base + DPMAIF_AO_UL_AP_L2TIMR0,
> > +					value, (value & ul_int_que_done) == ul_int_que_done, 0,
> > +					DPMAIF_CHECK_TIMEOUT_US);
> > +	if (ret)
> > +		dev_err(dpmaif_ctrl->dev,
> > +			"Could not mask the UL interrupt. DPMAIF_AO_UL_AP_L2TIMR0 is 0x%x\n",
> > +			value);
> 
> I would recommend to add a small patch that extends iopoll.h by ioreadXX() variants.
> 
> Or as alternative just define it here at the top of the file (or in one of the
> header if it's used more than in one module) so we may move it to the iopoll.h
> in the future:
> 
> 
> #define ioread32_poll_timeout_atomic(addr, val, cond, delay_us, timeout_us) \
> 	readx_poll_timeout_atomic(ioread32, addr, val, cond, delay_us, timeout_us)
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

-- 
With Best Regards,
Andy Shevchenko