MIME-Version: 1.0
References: <20211207125430.2423871-1-arnd@kernel.org>
In-Reply-To: <20211207125430.2423871-1-arnd@kernel.org>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 7 Dec 2021 15:10:08 +0100
Message-ID: <CAK8P3a1uMmgKw=drPhJWCdatzbm1+9FPZ6=-YMme+9n+f3xuXQ@mail.gmail.com>
Subject: Re: [PATCH] iwlwifi: work around reverse dependency on MEI
To:     Luca Coelho <luciano.coelho@intel.com>,
        Kalle Valo <kvalo@codeaurora.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        Ayala Beker <ayala.beker@intel.com>,
        Miri Korenblit <miriam.rachel.korenblit@intel.com>,
        Johannes Berg <johannes.berg@intel.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 7, 2021 at 1:54 PM Arnd Bergmann <arnd@kernel.org> wrote:
> diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
> index cf1125d84929..474afc6f82a8 100644
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -93,10 +93,10 @@ config IWLWIFI_BCAST_FILTERING
>           expect incoming broadcasts for their normal operations.
>
>  config IWLMEI
> -       tristate "Intel Management Engine communication over WLAN"
> -       depends on INTEL_MEI
> +       bool "Intel Management Engine communication over WLAN"
> +       depends on INTEL_MEI=y || INTEL_MEI=IWLMVM
> +       depends on IWLMVM=y || IWLWIFI=m

For reference, that line is wrong, and I still see the same problem
with my patch
applied. It should work after changing it to

        depends on IWLMVM=y || IWLMVM=m

but I'm still testing for further problems.

             Arnd