Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH v2] ath9k: switch to rate table based lookup
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20211128090753.958-1-jelonek.jonas@gmail.com>
References: <20211128090753.958-1-jelonek.jonas@gmail.com>
To:     Jonas Jelonek <jelonek.jonas@gmail.com>
Cc:     linux-wireless@vger.kernel.org, kvalo@codeaurora.org, nbd@nbd.name,
        toke@redhat.com, Jonas Jelonek <jelonek.jonas@gmail.com>,
        Thomas Huehn <thomas.huehn@hs-nordhausen.de>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <163889019720.23771.16292116056725581861.kvalo@kernel.org>
Date:   Tue,  7 Dec 2021 15:16:40 +0000 (UTC)
Precedence: bulk

Jonas Jelonek <jelonek.jonas@gmail.com> wrote:

> This patch changes mac80211 rate control for the ath9k driver.  The rate lookup
> per packet is changed from legacy usage of ieee80211_get_tx_rates() to the new
> rate table based lookup in struct ieee80211_sta->rates.
> 
> The most recent rate control API, introduced with commit 0d528d85c519
> ("mac80211: improve the rate control API"), allows drivers to directly get
> rates from ieee80211_sta->rates. This is not used by every driver yet, the
> translation/merge is currently performed in ieee80211_get_tx_rates.  This patch
> changes the behaviour and avoids the call to ieee80211_get_tx_rates and
> subsequent calls. ath9k now directly reads rates from sta->rates into its rate
> table. Cause ath9k does not expect rate selection in SKB->CB, the table merge
> does not consider rate array in SKB->CB except for the first entry (used for
> probing).
> 
> Tested with a 8devices Rambutan with QCA9558 SoC by performing two runs, one
> without the patch and one with. Generated traffic between AP and multiple STAs
> in each run, measured throughput and captured rc_stats.  Comparison of both
> runs resulted in same rate selection and no performance loss or other negative
> effects.
> 
> Co-developed-by: Thomas Huehn <thomas.huehn@hs-nordhausen.de>
> Signed-off-by: Thomas Huehn <thomas.huehn@hs-nordhausen.de>
> Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
> Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

7f3a6f5dd207 ath9k: switch to rate table based lookup

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211128090753.958-1-jelonek.jonas@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches