Subject: Re: [PATCH 2/2] wilc1000: Fix missing newline in error message
To:     Joe Perches <joe@perches.com>,
        Ajay Singh <ajay.kathat@microchip.com>
Cc:     Claudiu Beznea <claudiu.beznea@microchip.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211206232709.3192856-1-davidm@egauge.net>
 <20211206232709.3192856-3-davidm@egauge.net>
 <4687b01640eaaba01b3db455a7951a534572ee31.camel@perches.com>
From:   David Mosberger-Tang <davidm@egauge.net>
Message-ID: <00d44cb3-3b38-7bb6-474f-c819c2403b6a@egauge.net>
Date:   Tue, 7 Dec 2021 15:58:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <4687b01640eaaba01b3db455a7951a534572ee31.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

On 12/6/21 6:33 PM, Joe Perches wrote:

> On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote:
>> Add missing newline in pr_err() message.
> []
>> diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c
> []
>> @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data)
>>   	struct wilc *wilc = user_data;
>>   
>>   	if (wilc->close) {
>> -		pr_err("Can't handle UH interrupt");
>> +		pr_err("Can't handle UH interrupt\n");
> Ideally this would use wiphy_<level>:
>
> 		wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n");

Sure, but that's orthogonal to this bug fix.  I do have a "cleanups" 
branch with various cleanups of this sort.  I'll look into fixing pr_*() 
calls in the cleanups branch (there are several of them, unsurprisingly).


   --david