Message-ID: <6da1f2cc0ffc2c0106412c5aff52700edd183c6d.camel@egauge.net>
Subject: Re: [PATCH 2/2] wilc1000: Fix missing newline in error message
From:   David Mosberger-Tang <davidm@egauge.net>
To:     Joe Perches <joe@perches.com>,
        Ajay Singh <ajay.kathat@microchip.com>
Cc:     Claudiu Beznea <claudiu.beznea@microchip.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Tue, 07 Dec 2021 19:19:05 -0700
In-Reply-To: <5b44cebddcda765942aa118d25740a074137d0f8.camel@perches.com>
References: <20211206232709.3192856-1-davidm@egauge.net>
         <20211206232709.3192856-3-davidm@egauge.net>
         <4687b01640eaaba01b3db455a7951a534572ee31.camel@perches.com>
         <00d44cb3-3b38-7bb6-474f-c819c2403b6a@egauge.net>
         <5b44cebddcda765942aa118d25740a074137d0f8.camel@perches.com>
Organization: eGauge Systems LLC
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2021-12-07 at 16:23 -0800, Joe Perches wrote:
> On Tue, 2021-12-07 at 15:58 -0700, David Mosberger-Tang wrote:
> > On 12/6/21 6:33 PM, Joe Perches wrote:
> > 
> > > On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote:
> > > > Add missing newline in pr_err() message.
> > > []
> > > > diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c
> > > []
> > > > @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data)
> > > >   	struct wilc *wilc = user_data;
> > > >   
> > > >   	if (wilc->close) {
> > > > -		pr_err("Can't handle UH interrupt");
> > > > +		pr_err("Can't handle UH interrupt\n");
> > > Ideally this would use wiphy_<level>:
> > > 
> > > 		wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n");
> > 
> > Sure, but that's orthogonal to this bug fix.
> 
> Of course.
> 
> >  I do have a "cleanups" 
> > branch with various cleanups of this sort.  I'll look into fixing pr_*() 
> > calls in the cleanups branch (there are several of them, unsurprisingly).
> 
> netdev_<level> -> wiphy_<level> conversions too where feasible please.

OK, I made a note for that, too, thanks.

  --david