Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wcn36xx: Fix max channels retrieval
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <1638435732-14657-1-git-send-email-loic.poulain@linaro.org>
References: <1638435732-14657-1-git-send-email-loic.poulain@linaro.org>
To:     Loic Poulain <loic.poulain@linaro.org>
Cc:     kvalo@codeaurora.org, wcn36xx@lists.infradead.org,
        linux-wireless@vger.kernel.org,
        Loic Poulain <loic.poulain@linaro.org>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <163895245805.29041.12821453158667159636.kvalo@kernel.org>
Date:   Wed,  8 Dec 2021 08:34:19 +0000 (UTC)
Precedence: bulk

Loic Poulain <loic.poulain@linaro.org> wrote:

> Kernel test robot reported:drivers/net/wireless/ath/wcn36xx/smd.c:943:33:
>    sparse: sparse: cast truncates bits from constant value (780 becomes 80)
> 
> The 'channels' field is not a simple u8 array but an array of
> channel_params. Using sizeof for retrieving the max number of
> channels is then wrong.
> 
> In practice, it was not an issue, because the sizeof returned
> value is 780, which is truncated in min_t (u8) to 80, which is
> the value we expect...
> 
> Fix that properly using ARRAY_SIZE instead of sizeof.
> 
> Fixes: d707f812bb05 ("wcn36xx: Channel list update before hardware scan")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

09cab4308bf9 wcn36xx: Fix max channels retrieval

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1638435732-14657-1-git-send-email-loic.poulain@linaro.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches