Date:   Wed, 8 Dec 2021 06:50:25 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Kalle Valo <kvalo@kernel.org>
Cc:     netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: pull-request: wireless-drivers-next-2021-12-07
Message-ID: <20211208065025.7060225d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <87tufjfrw0.fsf@codeaurora.org>
References: <20211207144211.A9949C341C1@smtp.kernel.org>
        <20211207211412.13c78ace@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <87tufjfrw0.fsf@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 08 Dec 2021 10:00:15 +0200 Kalle Valo wrote:
> Jakub Kicinski <kuba@kernel.org> writes:
> 
> > On Tue,  7 Dec 2021 14:42:11 +0000 (UTC) Kalle Valo wrote:  
> >> here's a pull request to net-next tree, more info below. Please let me know if
> >> there are any problems.  
> >
> > Pulled, thanks! Could you chase the appropriate people so that the new
> > W=1 C=1 warnings get resolved before the merge window's here?
> >
> > https://patchwork.kernel.org/project/netdevbpf/patch/20211207144211.A9949C341C1@smtp.kernel.org/  
> 
> Just so that I understand right, you are referring to this patchwork
> test:
> 
>   Errors and warnings before: 111 this patch: 115
> 
>   https://patchwork.hopto.org/static/nipa/591659/12662005/build_32bit/
> 
> And you want the four new warnings to be fixed? That can be quite time
> consuming, to be honest I would rather revert the commits than using a
> lot of my time trying to get people fix the warnings. Is there an easy
> way to find what are the new warnings?

Yeah, scroll down, there is a diff of the old warnings vs new ones, and
a summary of which files have changed their warning count:

+      2 ../drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+      3 ../drivers/net/wireless/intel/iwlwifi/mei/main.c
-      1 ../drivers/net/wireless/intel/iwlwifi/mvm/ops.c
+      2 ../drivers/net/wireless/intel/iwlwifi/mvm/ops.c
-      2 ../drivers/net/wireless/microchip/wilc1000/wlan.c

So presumably these are the warnings that were added:

drivers/net/wireless/intel/iwlwifi/mei/main.c:193: warning: cannot understand function prototype: 'struct '
drivers/net/wireless/intel/iwlwifi/mei/main.c:1784: warning: Function parameter or member 'cldev' not described in 'iwl_mei_probe'
drivers/net/wireless/intel/iwlwifi/mei/main.c:1784: warning: Function parameter or member 'id' not described in 'iwl_mei_probe'

drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:3911:28: warning: incorrect type in assignment (different base types)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:3911:28:    expected restricted __le32 [assigned] [usertype] period_msec
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:3911:28:    got restricted __le16 [usertype]
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:3913:30: warning: incorrect type in assignment (different base types)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:3913:30:    expected unsigned char [assigned] [usertype] keep_alive_id
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:3913:30:    got restricted __le16 [usertype]

drivers/net/wireless/intel/iwlwifi/mvm/ops.c:684:12: warning: context imbalance in 'iwl_mvm_start_get_nvm' - wrong count at exit

> But in the big picture are you saying the net trees now have a rule that
> no new W=1 and C=1 warnings are allowed? I do test ath10k and ath11k
> drivers for W=1 and C=1 warnings, but all other drivers are on their own
> in this regard. At the moment I have no tooling in place to check all
> wireless drivers.

For the code we merge directly we try to make sure there are no new
warnings. I realize it's quite a bit of work for larger trees unless 
you have the infra so not a hard requirement (for you).

FWIW the build bot we wrote is available on GH:

https://github.com/kuba-moo/nipa

But it currently hard codes tree matching logic for bpf and netdev,
so would probably take a few hours to adopt it.