From:   Kalle Valo <kvalo@kernel.org>
To:     Carl Huang <cjhuang@codeaurora.org>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/6] ath11k: purge rx pktlog when entering WoW
References: <20211011193750.4891-1-cjhuang@codeaurora.org>
        <20211011193750.4891-5-cjhuang@codeaurora.org>
Date:   Thu, 09 Dec 2021 17:12:41 +0200
In-Reply-To: <20211011193750.4891-5-cjhuang@codeaurora.org> (Carl Huang's
        message of "Mon, 11 Oct 2021 15:37:48 -0400")
Message-ID: <87v8zxzuae.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Carl Huang <cjhuang@codeaurora.org> writes:

> This change is to purge rx pktlog when entering WoW and reap
> the mon_status buffer to keep it empty. When leaving WoW, host
> restarts the reap timer. In WoW state, it's not allowed to feed
> into mon_status rings per firmware request.

"per firmware request" is not clear for me. Do you "per firmware team's
recommendation" or what?

> @@ -327,12 +327,7 @@ int ath11k_core_resume(struct ath11k_base *ab)
>  	ath11k_hif_ce_irq_enable(ab);
>  	ath11k_hif_irq_enable(ab);
>  
> -	ret = ath11k_dp_rx_pktlog_start(ab);
> -	if (ret) {
> -		ath11k_warn(ab, "failed to start rx pktlog during resume: %d\n",
> -			    ret);
> -		return ret;
> -	}
> +	ath11k_dp_rx_pktlog_start(ab);

Why remove error handling? We should always handle the errors.

>  
>  	ret = ath11k_wow_wakeup(ab);
>  	if (ret) {
> diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
> index 6d769ba..ae6db5d 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
> @@ -5105,13 +5105,11 @@ int ath11k_dp_rx_pdev_mon_detach(struct ath11k *ar)
>  	return 0;
>  }
>  
> -int ath11k_dp_rx_pktlog_start(struct ath11k_base *ab)
> +void ath11k_dp_rx_pktlog_start(struct ath11k_base *ab)
>  {
>  	/* start reap timer */
>  	mod_timer(&ab->mon_reap_timer,
>  		  jiffies + msecs_to_jiffies(ATH11K_MON_TIMER_INTERVAL));
> -
> -	return 0;
>  }

Ah, you remove it here as well. But for consistency it's better to have
this return an error code.

> @@ -640,6 +657,8 @@ int ath11k_wow_op_resume(struct ieee80211_hw *hw)
>  	ath11k_hif_ce_irq_enable(ar->ab);
>  	ath11k_hif_irq_enable(ar->ab);
>  
> +	ath11k_dp_rx_pktlog_start(ar->ab);

Error handling here as well, please.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches