From:   Kalle Valo <kvalo@kernel.org>
To:     Carl Huang <cjhuang@codeaurora.org>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/6] ath11k: implement hw data filter
References: <20211011193750.4891-1-cjhuang@codeaurora.org>
        <20211011193750.4891-4-cjhuang@codeaurora.org>
Date:   Thu, 09 Dec 2021 17:47:10 +0200
In-Reply-To: <20211011193750.4891-4-cjhuang@codeaurora.org> (Carl Huang's
        message of "Mon, 11 Oct 2021 15:37:47 -0400")
Message-ID: <87mtl9zsox.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Carl Huang <cjhuang@codeaurora.org> writes:

> Host needs to set hw data filter before entering WoW to
> let firmware drop needless bc/mc frames to avoid frequent wakeup.
> Host clears hw data filter when leaving WoW.
>
> Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1
>
> Signed-off-by: Carl Huang <cjhuang@codeaurora.org>

[...]

> @@ -598,8 +647,14 @@ int ath11k_wow_op_resume(struct ieee80211_hw *hw)
>  	}
>  
>  	ret = ath11k_wow_nlo_cleanup(ar);
> -	if (ret)
> +	if (ret) {
>  		ath11k_warn(ar->ab, "failed to cleanup nlo: %d\n", ret);
> +		goto exit;
> +	}
> +
> +	ret = ath11k_wow_clear_hw_filter(ar);
> +	if (ret)
> +		ath11k_warn(ar->ab, "failed to clear hw filter: %d\n", ret);
>  
>  exit:
>  	if (ret) {

For consistency please add goto exit for ath11k_wow_clear_hw_filter().

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches