From:   Kalle Valo <kvalo@kernel.org>
To:     Wen Gong <quic_wgong@quicinc.com>
Cc:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 01/15] ath11k: add support for extended wmi service bit
References: <20211026111913.7346-1-quic_wgong@quicinc.com>
        <20211026111913.7346-2-quic_wgong@quicinc.com>
Date:   Thu, 09 Dec 2021 18:16:41 +0200
In-Reply-To: <20211026111913.7346-2-quic_wgong@quicinc.com> (Wen Gong's
        message of "Tue, 26 Oct 2021 07:18:59 -0400")
Message-ID: <87fsr1wy6u.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Wen Gong <quic_wgong@quicinc.com> writes:

> The max wmi service bit is 256 in ath11k, Extend it
> for more wmi service bit.
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
>
> Signed-off-by: Wen Gong <quic_wgong@quicinc.com>

[...]

> --- a/drivers/net/wireless/ath/ath11k/wmi.h
> +++ b/drivers/net/wireless/ath/ath11k/wmi.h
> @@ -2059,7 +2059,9 @@ enum wmi_tlv_service {
>  	WMI_TLV_SERVICE_EXT2_MSG = 220,
>  	WMI_TLV_SERVICE_SRG_SRP_SPATIAL_REUSE_SUPPORT = 249,
>  
> -	WMI_MAX_EXT_SERVICE
> +	WMI_MAX_EXT_SERVICE = 256,
> +
> +	WMI_MAX_EXT2_SERVICE
>  };
>  
>  enum {
> @@ -5066,7 +5068,7 @@ struct ath11k_wmi_base {
>  
>  	struct completion service_ready;
>  	struct completion unified_ready;
> -	DECLARE_BITMAP(svc_map, WMI_MAX_EXT_SERVICE);
> +	DECLARE_BITMAP(svc_map, WMI_MAX_EXT2_SERVICE);

I don't get this, why do we need two MAX enums? Please explain in the
commit log.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches