From:   Kalle Valo <kvalo@kernel.org>
To:     Tzung-Bi Shih <tzungbi@google.com>
Cc:     nbd@nbd.name, lorenzo.bianconi83@gmail.com, ryder.lee@mediatek.com,
        shayne.chen@mediatek.com, sean.wang@mediatek.com,
        linux-wireless@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mt76: mt7921: reduce log severity levels for informative messages
References: <20211210082247.977043-1-tzungbi@google.com>
Date:   Fri, 10 Dec 2021 10:49:11 +0200
In-Reply-To: <20211210082247.977043-1-tzungbi@google.com> (Tzung-Bi Shih's
        message of "Fri, 10 Dec 2021 16:22:47 +0800")
Message-ID: <8735n0oneg.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Tzung-Bi Shih <tzungbi@google.com> writes:

> "ASIC revision" and "Firmware init done" shouldn't be error messages.
> Reduces the severity level to info.
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 2 +-
>  drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> index 6ada1ebe7d68..99b144fd8db5 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> @@ -882,7 +882,7 @@ static int mt7921_load_firmware(struct mt7921_dev *dev)
>  	dev->mt76.hw->wiphy->wowlan = &mt76_connac_wowlan_support;
>  #endif /* CONFIG_PM */
>  
> -	dev_err(dev->mt76.dev, "Firmware init done\n");
> +	dev_info(dev->mt76.dev, "Firmware init done\n");

Shouldn't that be a debug message? Hard to see how's that useful in
normal operation.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches