MIME-Version: 1.0
References: <20211210082247.977043-1-tzungbi@google.com> <8735n0oneg.fsf@tynnyri.adurom.net>
In-Reply-To: <8735n0oneg.fsf@tynnyri.adurom.net>
From:   Tzung-Bi Shih <tzungbi@google.com>
Date:   Fri, 10 Dec 2021 17:19:50 +0800
Message-ID: <CA+Px+wXbeeHw5TgOk4yY7EdL-BTc124HDgtR6bmmm1X4VQtqjA@mail.gmail.com>
Subject: Re: [PATCH] mt76: mt7921: reduce log severity levels for informative messages
To:     Kalle Valo <kvalo@kernel.org>
Cc:     nbd@nbd.name, lorenzo.bianconi83@gmail.com, ryder.lee@mediatek.com,
        shayne.chen@mediatek.com, sean.wang@mediatek.com,
        linux-wireless@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Dec 10, 2021 at 4:49 PM Kalle Valo <kvalo@kernel.org> wrote:
>
> Tzung-Bi Shih <tzungbi@google.com> writes:
[...]
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > index 6ada1ebe7d68..99b144fd8db5 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > @@ -882,7 +882,7 @@ static int mt7921_load_firmware(struct mt7921_dev *dev)
> >       dev->mt76.hw->wiphy->wowlan = &mt76_connac_wowlan_support;
> >  #endif /* CONFIG_PM */
> >
> > -     dev_err(dev->mt76.dev, "Firmware init done\n");
> > +     dev_info(dev->mt76.dev, "Firmware init done\n");
>
> Shouldn't that be a debug message? Hard to see how's that useful in
> normal operation.

I thought the message was an indicator of "the firmware is loaded
completely".  Sent v2 to use dbg instead.