From:   Kalle Valo <kvalo@kernel.org>
To:     Loic Poulain <loic.poulain@linaro.org>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: Fix incorrect type assignments for keep-alive
References: <1638953708-29192-1-git-send-email-loic.poulain@linaro.org>
        <163942183691.6700.15831682111724282439.kvalo@kernel.org>
Date:   Mon, 13 Dec 2021 21:04:33 +0200
In-Reply-To: <163942183691.6700.15831682111724282439.kvalo@kernel.org> (Kalle
        Valo's message of "Mon, 13 Dec 2021 18:57:18 +0000 (UTC)")
Message-ID: <87tufcmim6.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Kalle Valo <kvalo@kernel.org> writes:

> Loic Poulain <loic.poulain@linaro.org> wrote:
>
>> cpu_to_le16 has been used for all keep-alive fields, but 'perdio_msec'
>> is a 32-bit field and 'keep_alive_id' a 8-bit one. Fix that.
>> 
>> Fixes: 7a6cfe28ae3e ("brcmfmac:  Configure keep-alive packet on suspend")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
>
> Patch applied to wireless-drivers-next.git, thanks.
>
> 78da5cca6ece brcmfmac: Fix incorrect type assignments for keep-alive

Actually the fixes tag was incorrect, I fixed it but the commit id changed:

3db30b790289 brcmfmac: Fix incorrect type assignments for keep-alive

The error was:

In commit

  78da5cca6ece ("brcmfmac: Fix incorrect type assignments for keep-alive")

Fixes tag

  Fixes: 7a6cfe28ae3e ("brcmfmac:  Configure keep-alive packet on suspend")

has these problem(s):

  - Subject does not match target commit subject
      Just use
           git log -1 --format='Fixes: %h ("%s")'

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches