Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wilc1000: Remove misleading USE_SPI_DMA macro
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20211207002453.3193737-1-davidm@egauge.net>
References: <20211207002453.3193737-1-davidm@egauge.net>
To:     David Mosberger-Tang <davidm@egauge.net>
Cc:     Ajay Singh <ajay.kathat@microchip.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        David Mosberger-Tang <davidm@egauge.net>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <163950748948.16030.12912996854726800768.kvalo@kernel.org>
Date:   Tue, 14 Dec 2021 18:44:50 +0000 (UTC)
Precedence: bulk

David Mosberger-Tang <davidm@egauge.net> wrote:

> The USE_SPI_DMA macro name suggests that it could be set to 1 to
> control whether or not SPI DMA should be used.  However, that's not
> what it does.  If set to 1, it'll set the SPI messages'
> "is_dma_mapped" flag to true, even though the tx/rx buffers aren't
> actually DMA mapped by the driver.  In other words, setting this flag
> to 1 will break the driver.
> 
> Best to clean up this confusion by removing the macro altogether.
> There is no need to explicitly initialize "is_dma_mapped" because the
> message is cleared to zero anyhow, so "is_dma_mapped" is set to false
> by default.
> 
> Signed-off-by: David Mosberger-Tang <davidm@egauge.net>
> Acked-by: Ajay Singh <ajay.kathat@microchip.com>

Patch applied to wireless-drivers-next.git, thanks.

dde02213fa64 wilc1000: Remove misleading USE_SPI_DMA macro

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211207002453.3193737-1-davidm@egauge.net/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches