Date:   Thu, 16 Dec 2021 13:17:06 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     emmanuel.grumbach@intel.com
Cc:     linux-wireless@vger.kernel.org
Subject: [bug report] iwlwifi: mei: add the driver to allow cooperation with
 CSME
Message-ID: <20211216101706.GA20233@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5JjJF5YMqUuljFdo+1cedkVazRt88IOpoyW0JeDcNv5ib4QWYZGdMF4jeS4r?=
 =?us-ascii?Q?frfhqvKxpHv33tahrN8qfpvyEyAh1Q+DGtPlO3hKHl/wmAoDA3UJOSNGaqlF?=
 =?us-ascii?Q?QFpcNS8WnwvAQug43REj8rrFELpenAHILMjB3rgdJ72Gl0uookMbKsZkA5zy?=
 =?us-ascii?Q?g9B0xk++fqmFz4M/TWgIrTEnQv3a/xB8tpTk+rSGrvTXz5M/LrlEmlQhaVOK?=
 =?us-ascii?Q?yyiBJo7SUwNDWuW8iX9sF2/jjr01SbSXZdDOMJHBqRrCXpfcqS+ZAH9dE6ID?=
 =?us-ascii?Q?2wAEMQOy+1W+YzpwKCT00quKqC7qnyAYZK/d5YdhMTxAlOxTRwuP+MQ8W7wl?=
 =?us-ascii?Q?YY20XqumiyfZXE4FJBZ4ed4aHNhcvBpUNhLrCPo0ktbWfGyHzP/tf7WaWfKT?=
 =?us-ascii?Q?Jsf13u7B2xFMGNnK5SJecB6OGxmmsYNKtdY1EBqvPra7AYK0dhDA8IpyBNDu?=
 =?us-ascii?Q?/IkCKk1Dx0lQIHkrX3f55lozlmWKrZkvmkgho2FJ5ZsULTRDjB46eAEpa9GM?=
 =?us-ascii?Q?efB8Q8L8Y21yxdlbXdRGOhtxZze311kiT9CkloS2VpqRlb8K5Ufqn1WeS0tw?=
 =?us-ascii?Q?xka75Hn+H/84oXIrGYMoJUIVKE5FvtEs+WGysIjYwsykNX+gevUq0G2TIjH4?=
 =?us-ascii?Q?KIz4El3UCdOWolVkQVbpQ+bYCznU236My2Mv1vVIg1UvIjCSweA6M2lHWBHH?=
 =?us-ascii?Q?wN/B2C+yszy8sfIrv7MZ9vwRNt9OKh2m36C83FNvjVB3QJAT3RY7fAj9DgCe?=
 =?us-ascii?Q?ZQGvwWeMcJJlAyooHbghCgTouotazZvAOjIAv3vTmntdlKwObMIa6mulUNcF?=
 =?us-ascii?Q?qJbaurSPBI0EEEmcwtVFwu6IE6Cx6mbtMtYAFOZPMcN/1AaaWJybKa5jOmW3?=
 =?us-ascii?Q?tQNQ9GdqiEPQ3LbGMDijVB6js0Cnl/QClpuENFqvt0Dt4f7tyjZ1T6hL9m7+?=
 =?us-ascii?Q?xPGvGQ2A5woN5Y1FZUq0CE/Dx1EvwzG27sVsf38a2Cep77maReBtYI35pXkn?=
 =?us-ascii?Q?h445eVThIEuJgVJAn27jdFbNaJaXgCKxBxye5pMaubIZF7WxmTYYdaTJA7gT?=
 =?us-ascii?Q?mfI1QmUYPP5W5wD5vIsu3C5WhHhqGQ+2ws/KGo/yjrmbFHEsjNGOxb+Ji0sj?=
 =?us-ascii?Q?O1RISoLzbcMEjUBmr5AdOBytI7+3WpAMk1oCiGtjUAReml7WXYlETPVrS4sw?=
 =?us-ascii?Q?OOc1+MtIUoXG3hUhW/7jPcRxRL15bxbfkwNOyfxq9zQXOThFBMqw3HCG09J8?=
 =?us-ascii?Q?chKWoEVtdHJ9iT/1cwFTZ6MIdbCyq+Amb0fKwqBkk+dIZ3BcKmMFM7XjFcYN?=
 =?us-ascii?Q?yzO65j8ODKj64Cbe6ESQs0aWkc0mahrAjW1kMpfVKDbTOHnw6lQtAKi531h0?=
 =?us-ascii?Q?u2xXKE707SK/A+k6vZWFWOxFoaodxH2bTPOrCPxEE42FSCXMzD46uwZhFSKS?=
 =?us-ascii?Q?TvNGoqyT/0AxF1kkw381eyexzMw6mmSTS6kNVcc7uofSLxEQr+UYFuHckKGa?=
 =?us-ascii?Q?DlvSfVlGdy+PMTnrApL8UgmiFu5zOL8VZ0JIeDAc1xkfWBIc9gdZ3IWHHNf0?=
 =?us-ascii?Q?aKZmDgrTFi0IGnnpgh3j8HkdhkZwtpTw4Z4V7mDqQsfqI34Aihm44MGDdObp?=
 =?us-ascii?Q?nCH5+T/P7gdWo3FNH5HKbgrEqTT/ZHVeBmiHLglzQSfOCFTok2tnPQicKniD?=
 =?us-ascii?Q?yVhLIrMs1W6QfyzwCqmJnklfLxk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef57043d-d2c9-4f91-a19a-08d9c07d3ccc
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 10:17:17.6772
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d2g/uOYDIAguhX2DDODTj6bbasuD3DjGOJeTXuaY9Pm1wlmwCFKLGfpAY6CqHTCOoZQvO6ET/JvMkRslHaapcTgAzfNnwnI4sC5p9gauRis=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4449
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10199 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=930 phishscore=0
 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112160058
X-Proofpoint-ORIG-GUID: V1kB8fc186aoHuQmVd4X_C7Nt0K1r8RY
X-Proofpoint-GUID: V1kB8fc186aoHuQmVd4X_C7Nt0K1r8RY
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hello Emmanuel Grumbach,

The patch 2da4366f9e2c: "iwlwifi: mei: add the driver to allow
cooperation with CSME" from Nov 12, 2021, leads to the following
Smatch static checker warning:

	drivers/net/wireless/intel/iwlwifi/mei/net.c:199 iwl_mei_rx_filter_ipv4()
	warn: taking sizeof binop

drivers/net/wireless/intel/iwlwifi/mei/net.c
    188 static bool iwl_mei_rx_filter_ipv4(struct sk_buff *skb,
    189                                    const struct iwl_sap_oob_filters *filters,
    190                                    rx_handler_result_t *rx_handler_res)
    191 {
    192         const struct iwl_sap_ipv4_filter *filt = &filters->ipv4_filter;
    193         const struct iphdr *iphdr;
    194         unsigned int iphdrlen;
    195         bool match;
    196 
    197         if (!pskb_may_pull(skb, skb_network_offset(skb) + sizeof(*iphdr)) ||
    198             !pskb_may_pull(skb, skb_network_offset(skb) +
--> 199                            sizeof(ip_hdrlen(skb) - sizeof(*iphdr))))

Probably this should be: ip_hdrlen(skb) - sizeof(*iphdr)?

    200                 return false;
    201 
    202         iphdrlen = ip_hdrlen(skb);

regards,
dan carpenter