From:   "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [bug report] iwlwifi: mei: add the driver to allow cooperation
 with CSME
Thread-Topic: [bug report] iwlwifi: mei: add the driver to allow cooperation
 with CSME
Thread-Index: AQHX8mYmSrAbT6NOxkul+y9hEQ4TbKw06NkQ
Date:   Thu, 16 Dec 2021 10:22:56 +0000
Message-ID: <SA1PR11MB58258BFD4BC44C26F8BD2FCFF2779@SA1PR11MB5825.namprd11.prod.outlook.com>
References: <20211216101706.GA20233@kili>
In-Reply-To: <20211216101706.GA20233@kili>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.200.16
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rjKYXkN5dojAkmOApv+mbqC2kLli5llohSDk1YwBStWrYOmsog+hjEDDClOu?=
 =?us-ascii?Q?+x8DvBQw7MRmgcK8a+HUeYT7yLx9G9Bu8lGcklHstAlVOHnGxIRASbnZV+Op?=
 =?us-ascii?Q?+xQ5KdAmZxlvm3jhJ2Ps7zs2rWzKTnF/uw35HCX4h4D37OCG+P2kugB+ddMn?=
 =?us-ascii?Q?SKrUgM54kgcixyv2EfFqlniewwSkZq/2Hn7P6wIrv6peCdcsTLC9l4e6BBgZ?=
 =?us-ascii?Q?Zknb5ZAU5yJg4TWJuWScx5HSaFdgiF3SbFSEdB6cLLhfAxk+1UAHhmt9rwRb?=
 =?us-ascii?Q?pgBwnY05OvVdBaLsGwLTK1raMqyZ/cDd97mwps1vwzlFQC30UHszr64GH0n1?=
 =?us-ascii?Q?ztyYWz5XtXVJx7wa3VKIYELznfH7QG1rdgVVnnrl4octLetUUJCeBz/cU2w6?=
 =?us-ascii?Q?X0R6YuJ06Q3HSk8qVIkyHuDhh2NXiAMQb750iEHusPggm3jO8hApASwrxqQB?=
 =?us-ascii?Q?5OkCreQdRv7DbacWGTtGV31y5n6/IgDryuMq1Ltujkjks0BMgGz1RDwqYdX0?=
 =?us-ascii?Q?ks+14FV80pvikCIFgLUzDTdvfBmJqIJmOqaQPKCuic0PcKADjpuAlrKQcvGv?=
 =?us-ascii?Q?JJUQJUw0apGhZFUAlvXh0sT5Txezo7HtmSeoUHSLaLrpKuKcQEIpCHXiOEIF?=
 =?us-ascii?Q?A9aCx/D6stNYzwh/O+tlxWLVft5CZ3fjs8BaLU17eYZ9tdaEJtja77AcrjFj?=
 =?us-ascii?Q?Mf9iAK19oOpIJZMD35YpGuC7P0yidQvQaoA4HoxTepFlWo/UYm70YrTwX+AP?=
 =?us-ascii?Q?xf27tY9ADsS2zaDIxAWjbdJg/4ODqU6+CxJ4CdKTl+Wz3pW/UrnyeBtlob0X?=
 =?us-ascii?Q?hRO60unYhlVPTZBpQYgvXWVRnduQ7GxAOLriDuVKLzNx6Hg/tNdBc7FiYdZx?=
 =?us-ascii?Q?56CgZGhE0Wy1eCUoG+lafZJhwOhqEJuMcijhL+V/289ahfL1Jz58ZNMBbquE?=
 =?us-ascii?Q?MsXIrQ23WP7AJ3ihwcFs68zcyXuAb8FYparewT99JRGlFvKlbdsPdVRsQ0De?=
 =?us-ascii?Q?0w+p4jimNF4SR3re4BIGfoOvLemG7cAvU+0/3L5toIg2zpgG3dNYEaHI3YMm?=
 =?us-ascii?Q?sCYLIW2acqTu4hOpADIVIYtc+NMa64DJGy791OXV+JaDFa/tPQn8gzdm/sqX?=
 =?us-ascii?Q?PScVOA45nZwYZtpC6LGrfuWlsFN3OK4NU50kKBh/8Z2byq0QlAtq2Zd807QS?=
 =?us-ascii?Q?C46V/YyZsHODRy2ncLlgCZ6RxnnFDdegggjRANAvoP0416OdgtXO5r+8HZu0?=
 =?us-ascii?Q?t1MW+dd7pywGI58JoMNDGXrN2etEmW+Hp1IS68//+SuDhvfaFZVmDbP1LlYy?=
 =?us-ascii?Q?wOe08bK5d1mUOGpKnQtvVY0trcdGetyWKDu/rtQVjmHSnUy8SVIKwJGDTQJZ?=
 =?us-ascii?Q?TQWmXbloJtyIIPLvYWUG1zHZ2RQF5fRPq36GamC9M8vssgKtbs5MVSj4Y2mJ?=
 =?us-ascii?Q?0QwAxngw3bnlQAaNqNgPDfSTlwyVEm5o+5xQNPLGEhPM2SeQ9JLbOjuvQfvC?=
 =?us-ascii?Q?UHKvEUWfoC0ARjFFl1i1XLk9wbviY/pgzs7Uf9txPCtpijyF08oe9SO1+GOS?=
 =?us-ascii?Q?Uz30qR8s5kLpExdR9kU+1rzHGSCcQKJurGhw4YBnLRECE1sth3V9LIA1EYdB?=
 =?us-ascii?Q?0J1MaQbCaTLDxn5gZMX6o29MRCBRJ8EhOUxWPHb54hAbjkC5wpKaGYYltw/9?=
 =?us-ascii?Q?N8gvmA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5825.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c401be6-b941-431e-ff09-08d9c07e06e3
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 10:22:56.2329
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: H5ELhOQMjYcXa7w+rZJg/7I1TOHM5qCaniU88h28g19SLwkRvGpLKXbi9LgCGz35SG25WSboernhmhcYAmfbZYSyoQE/7CnZ9g5QOgZsbPk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5826
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

> Hello Emmanuel Grumbach,
>=20
> The patch 2da4366f9e2c: "iwlwifi: mei: add the driver to allow cooperatio=
n
> with CSME" from Nov 12, 2021, leads to the following Smatch static checke=
r
> warning:
>=20
> 	drivers/net/wireless/intel/iwlwifi/mei/net.c:199
> iwl_mei_rx_filter_ipv4()
> 	warn: taking sizeof binop
>=20
> drivers/net/wireless/intel/iwlwifi/mei/net.c
>     188 static bool iwl_mei_rx_filter_ipv4(struct sk_buff *skb,
>     189                                    const struct iwl_sap_oob_filte=
rs *filters,
>     190                                    rx_handler_result_t *rx_handle=
r_res)
>     191 {
>     192         const struct iwl_sap_ipv4_filter *filt =3D &filters->ipv4=
_filter;
>     193         const struct iphdr *iphdr;
>     194         unsigned int iphdrlen;
>     195         bool match;
>     196
>     197         if (!pskb_may_pull(skb, skb_network_offset(skb) + sizeof(=
*iphdr))
> ||
>     198             !pskb_may_pull(skb, skb_network_offset(skb) +
> --> 199                            sizeof(ip_hdrlen(skb) - sizeof(*iphdr)=
)))
>=20
> Probably this should be: ip_hdrlen(skb) - sizeof(*iphdr)?

Ouch....
Thanks!