Message-ID: <59896f7e6382ddb34a63e78b489b2ded7bb1e980.camel@sipsolutions.net>
Subject: Re: [PATCH v2] mac80211: disable BSS color collision detection in
 case of no free colors
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Rameshkumar Sundaram <quic_ramess@quicinc.com>
Cc:     linux-wireless@vger.kernel.org,
        Lavanya Suresh <lavaks@codeaurora.org>
Date:   Mon, 20 Dec 2021 11:01:59 +0100
In-Reply-To: <1639307483-8055-1-git-send-email-quic_ramess@quicinc.com>
References: <1639307483-8055-1-git-send-email-quic_ramess@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.2 (3.42.2-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,


>  include/net/cfg80211.h |  28 +++++++------
>  net/mac80211/cfg.c     |  16 ++++++--
>  net/wireless/nl80211.c | 109 ++++++++++++++++++++++++-------------------------
>  3 files changed, 82 insertions(+), 71 deletions(-)
> 

This is now a fairly big cfg80211 change, and not much mac80211. Can you
please split it?

But you didn't really address why we need to do this via element change
detection, rather than letting hostapd do this via the
NL80211_ATTR_HE_BSS_COLOR attribute even in change_beacon?

johannes