Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] ath11k: Fix unexpected return buffer manager error for
 QCA6390
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20211222013536.582527-1-quic_bqiang@quicinc.com>
References: <20211222013536.582527-1-quic_bqiang@quicinc.com>
To:     Baochen Qiang <quic_bqiang@quicinc.com>
Cc:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <164019475894.13998.9287903984814236611.kvalo@kernel.org>
Date:   Wed, 22 Dec 2021 17:39:23 +0000 (UTC)
Precedence: bulk

Baochen Qiang <quic_bqiang@quicinc.com> wrote:

> We are seeing below error on QCA6390:
> ...
> [70211.671189] ath11k_pci 0000:72:00.0: failed to parse rx error in wbm_rel ring desc -22
> [70212.696154] ath11k_pci 0000:72:00.0: failed to parse rx error in wbm_rel ring desc -22
> [70213.092941] ath11k_pci 0000:72:00.0: failed to parse rx error in wbm_rel ring desc -22
> ...
> 
> The reason is that, with commit 734223d78428 ("ath11k: change return
> buffer manager for QCA6390"), ath11k expects the return buffer manager
> (RBM) field of descriptor configured as HAL_RX_BUF_RBM_SW1_BM when
> parsing error frames from WBM2SW3_RELEASE ring. This is a wrong change
> cause the RBM field is set as HAL_RX_BUF_RBM_SW3_BM.
> 
> The same issue also applies to REO2TCL ring though we have not got any
> error reported.
> 
> Fix it by changing RBM from HAL_RX_BUF_RBM_SW1_BM to HAL_RX_BUF_RBM_SW3_BM
> for these two rings.
> 
> Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1
> 
> Fixes: 734223d78428 ("ath11k: change return buffer manager for QCA6390")
> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

71c748b5e01e ath11k: Fix unexpected return buffer manager error for QCA6390

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211222013536.582527-1-quic_bqiang@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches