Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] brcmfmac: use ISO3166 country code and 0 rev as fallback
 on
 some devices
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20211218185643.158182-1-hdegoede@redhat.com>
References: <20211218185643.158182-1-hdegoede@redhat.com>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Arend van Spriel <aspriel@gmail.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Chi-Hsien Lin <chi-hsien.lin@infineon.com>,
        Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
        Wright Feng <wright.feng@infineon.com>,
        Hans de Goede <hdegoede@redhat.com>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        SHA-cyfmac-dev-list@infineon.com, Shawn Guo <shawn.guo@linaro.org>,
        Soeren Moch <smoch@web.de>,
        Fabio Aiuto <fabioaiuto83@gmail.com>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <164019530057.12144.15683892767137900754.kvalo@kernel.org>
Date:   Wed, 22 Dec 2021 17:48:23 +0000 (UTC)
Precedence: bulk

Hans de Goede <hdegoede@redhat.com> wrote:

> This is a second attempt at honering the country code send out by access
> points. This was first added in commit b0b524f079a2 ("brcmfmac: use
> ISO3166 country code and 0 rev as fallback").
> 
> Subsequently this was reverted in commit 151a7c12c4fc ("Revert "brcmfmac:
> use ISO3166 country code and 0 rev as fallback""), because it was causing
> issues with AP mode on some brcmfmac models (specifically on BCM4359/9).
> 
> Many devices ship with a nvram ccode value of X2/XT/XU/XV/ALL which are
> all special world-wide compatibility ccode-s. Most of these world-wide
> ccode-s allow passive scan mode only for 2.4GHz channels 12-14,
> only enabling them when an AP is seen on them.
> 
> But at least on brcmfmac43455 devices this is not working correctly, these
> do not see accesspoints on channels 12-14 unless the ccode is changes to
> a country where these channels are allowed.
> 
> Translating received country codes to an ISO3166 country code and 0 rev
> ccreq fixes devices using a brcmfmac43455 with a X2/XT/XU/XV/ALL ccode
> not seeing accesspoints on channels 12-14.
> 
> To avoid this causing issues on other brcmfmac models again, the
> fallback is limited to only brcmfmac4345* chips this time.
> 
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Soeren Moch <smoch@web.de>
> Cc: Fabio Aiuto <fabioaiuto83@gmail.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Arend, can you take a look?

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211218185643.158182-1-hdegoede@redhat.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches