Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D3BEC4167D for ; Wed, 29 Dec 2021 14:06:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237255AbhL2OGe (ORCPT ); Wed, 29 Dec 2021 09:06:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:47611 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239742AbhL2OGd (ORCPT ); Wed, 29 Dec 2021 09:06:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640786793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aO/4Yp6T43XLmNMDQP+OwTqaYv7whlIlyBDq4dbPFsg=; b=H4uN9kuFYKp06DXETLs651CfCfMow5IxU1wso1WjUjemw+q+GszkuqbBaRHdFqRJfqqWGr MI2bpyBE0SmetWDmhcD93tlcZfxtVftbYE6NOfcNysHSFFWCWS9Wek9upKsTV+L2xR0Wos ZyHDbWLh2sVqDfFTa5QcqlrWVLJd6rs= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-571-nfbdOnJcN9yWX1u-7yoRUQ-1; Wed, 29 Dec 2021 09:06:31 -0500 X-MC-Unique: nfbdOnJcN9yWX1u-7yoRUQ-1 Received: by mail-qt1-f198.google.com with SMTP id w14-20020ac87e8e000000b002b6583adcfcso15810111qtj.0 for ; Wed, 29 Dec 2021 06:06:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aO/4Yp6T43XLmNMDQP+OwTqaYv7whlIlyBDq4dbPFsg=; b=3L/RRE7IS/tDP/8IR3OuNAMnKiFRZ9HjvTckPXcZ3gh825VTncFS/+DCE6fYy6d4HX OMPoGsN7+cEJHGJnPUwxd8TpcA45ZO2Ytm5RoqKf4oV4oYdZP2thKn+8boMFKFEVmNTH d6H6D5RG8MmP90N8wLMbys6o8EvsCJvntwxhjVwhk3eMLXqYWAXihIKkmk0ptzXr6yhF ICBTEPHTLUINZLcb6RNEfrEH1nUvNnZmsDfF6ygWmY3q3Vu3olfRaMfoFUouCexRQj0v ouJGkZ9UsonunOL/4HjfB3qvPVIkLM09pGxc03Kvg7e/qKl8a/AoA0iRy5gX2PZR/uXQ a/9A== X-Gm-Message-State: AOAM5321B5D5s/mcBvrBFW52VK2qr0dbViHNHtflCyK+NgzC/U4pvyEp FIhI3OPIoZIu0VxdUDaUw9XNz0hCsmCn/yx/mdIzmy+FueZ59ti5Zo6COlbvOhH8OjcvMitkCrX EAEvI6FiPMSOPV0f6ttgnJW1UYho= X-Received: by 2002:a05:620a:4003:: with SMTP id h3mr18549159qko.153.1640786790502; Wed, 29 Dec 2021 06:06:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJyimHrQiLRtzxiuwvtJVztliA6HApJnsXsaqWdLb9ltPripN76oNC87N68Zld9IushfHCBQfg== X-Received: by 2002:a05:620a:4003:: with SMTP id h3mr18549076qko.153.1640786790152; Wed, 29 Dec 2021 06:06:30 -0800 (PST) Received: from steredhat (host-87-10-236-9.retail.telecomitalia.it. [87.10.236.9]) by smtp.gmail.com with ESMTPSA id h2sm18124352qkn.136.2021.12.29.06.06.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Dec 2021 06:06:29 -0800 (PST) Date: Wed, 29 Dec 2021 15:05:57 +0100 From: Stefano Garzarella To: Jakub Kicinski Cc: ast@kernel.org, daniel@iogearbox.net, bpf@vger.kernel.org, netdev@vger.kernel.org, Marc Kleine-Budde , marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, dledford@redhat.com, jgg@ziepe.ca, mustafa.ismail@intel.com, shiraz.saleem@intel.com, leon@kernel.org, ap420073@gmail.com, wg@grandegger.com, woojung.huh@microchip.com, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, george.mccollister@gmail.com, michael.chan@broadcom.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, hawk@kernel.org, john.fastabend@gmail.com, tariqt@nvidia.com, saeedm@nvidia.com, ecree.xilinx@gmail.com, habetsm.xilinx@gmail.com, jreuter@yaina.de, dsahern@kernel.org, kvalo@codeaurora.org, pkshih@realtek.com, trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, viro@zeniv.linux.org.uk, andrii@kernel.org, mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, nikolay@nvidia.com, jiri@nvidia.com, wintera@linux.ibm.com, wenjia@linux.ibm.com, pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, ralf@linux-mips.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, kgraul@linux.ibm.com, steffen.klassert@secunet.com, herbert@gondor.apana.org.au, arnd@arndb.de, linux-bluetooth@vger.kernel.org, linux-rdma@vger.kernel.org, linux-can@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-hams@vger.kernel.org, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, bridge@lists.linux-foundation.org, linux-decnet-user@lists.sourceforge.net, linux-s390@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h Message-ID: <20211229140557.cuap5jjqz47yevda@steredhat> References: <20211229004913.513372-1-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20211229004913.513372-1-kuba@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Dec 28, 2021 at 04:49:13PM -0800, Jakub Kicinski wrote: >sock.h is pretty heavily used (5k objects rebuilt on x86 after >it's touched). We can drop the include of filter.h from it and >add a forward declaration of struct sk_filter instead. >This decreases the number of rebuilt objects when bpf.h >is touched from ~5k to ~1k. > >There's a lot of missing includes this was masking. Primarily >in networking tho, this time. > >Acked-by: Marc Kleine-Budde >Signed-off-by: Jakub Kicinski >--- >v2: https://lore.kernel.org/all/20211228192519.386913-1-kuba@kernel.org/ > - fix build in bond on ia64 > - fix build in ip6_fib with randconfig For AF_VSOCK: Acked-by: Stefano Garzarella