MIME-Version: 1.0
References: <20211229004913.513372-1-kuba@kernel.org>
In-Reply-To: <20211229004913.513372-1-kuba@kernel.org>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Wed, 29 Dec 2021 08:51:23 -0800
Message-ID: <CAADnVQLd2y_Cuqrn+cAQzCjpXM_Lub5_X6xEfZdMMC2a2Jq41A@mail.gmail.com>
Subject: Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        bpf <bpf@vger.kernel.org>,
        Network Development <netdev@vger.kernel.org>,
        Marc Kleine-Budde <mkl@pengutronix.de>, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@ziepe.ca>, mustafa.ismail@intel.com,
        shiraz.saleem@intel.com, Leon Romanovsky <leon@kernel.org>,
        Taehee Yoo <ap420073@gmail.com>, wg@grandegger.com,
        woojung.huh@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        vivien.didelot@gmail.com, Florian Fainelli <f.fainelli@gmail.com>,
        olteanv@gmail.com, george.mccollister@gmail.com,
        Michael Chan <michael.chan@broadcom.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        anthony.l.nguyen@intel.com,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Tariq Toukan <tariqt@nvidia.com>, saeedm@nvidia.com,
        ecree.xilinx@gmail.com, habetsm.xilinx@gmail.com, jreuter@yaina.de,
        David Ahern <dsahern@kernel.org>, kvalo@codeaurora.org,
        pkshih@realtek.com, trond.myklebust@hammerspace.com,
        anna.schumaker@netapp.com,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Andrii Nakryiko <andrii@kernel.org>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Iurii Zaikin <yzaikin@google.com>, nikolay@nvidia.com,
        jiri@nvidia.com, wintera@linux.ibm.com, wenjia@linux.ibm.com,
        Pablo Neira Ayuso <pablo@netfilter.org>,
        Jozsef Kadlecsik <kadlec@netfilter.org>,
        Florian Westphal <fw@strlen.de>,
        Ralf Baechle <ralf@linux-mips.org>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>, kgraul@linux.ibm.com,
        sgarzare@redhat.com,
        Steffen Klassert <steffen.klassert@secunet.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Arnd Bergmann <arnd@arndb.de>, linux-bluetooth@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-can@vger.kernel.org,
        intel-wired-lan <intel-wired-lan@lists.osuosl.org>,
        linux-hams@vger.kernel.org, ath11k@lists.infradead.org,
        linux-wireless <linux-wireless@vger.kernel.org>,
        linux-nfs@vger.kernel.org,
        Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
        "moderated list:ETHERNET BRIDGE" <bridge@lists.linux-foundation.org>,
        linux-decnet-user@lists.sourceforge.net,
        linux-s390 <linux-s390@vger.kernel.org>,
        netfilter-devel <netfilter-devel@vger.kernel.org>,
        coreteam@netfilter.org, virtualization@lists.linux-foundation.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 28, 2021 at 4:49 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> sock.h is pretty heavily used (5k objects rebuilt on x86 after
> it's touched). We can drop the include of filter.h from it and
> add a forward declaration of struct sk_filter instead.
> This decreases the number of rebuilt objects when bpf.h
> is touched from ~5k to ~1k.
>
> There's a lot of missing includes this was masking. Primarily
> in networking tho, this time.
>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> v2: https://lore.kernel.org/all/20211228192519.386913-1-kuba@kernel.org/
>  - fix build in bond on ia64
>  - fix build in ip6_fib with randconfig

Nice! Applied. Thanks