Message-ID: <bbf4b392e557a36f45a8642682512964502a4196.camel@sipsolutions.net>
Subject: Re: [PATCH] mt76: mt7915: fix a couple information leaks
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Felix Fietkau <nbd@nbd.name>,
        Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Kalle Valo <kvalo@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        MeiChia Chiu <meichia.chiu@mediatek.com>,
        Money Wang <Money.Wang@mediatek.com>,
        linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org,
        kernel-janitors@vger.kernel.org
Date:   Fri, 07 Jan 2022 11:21:56 +0100
In-Reply-To: <97dbf02a-e3c7-aa4a-c404-45fc6189dc10@nbd.name>
References: <20220107073609.GH22086@kili>
         <f61c6a25c7ad1ed452b4facf38c7e451d47c5dc0.camel@sipsolutions.net>
         <97dbf02a-e3c7-aa4a-c404-45fc6189dc10@nbd.name>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.2 (3.42.2-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2022-01-07 at 11:08 +0100, Felix Fietkau wrote:
> > 
> > Or maybe instead just mark the thing __packed (and/or explicitly add the
> > padding if needed), it seems weird that we'd send something to the
> > *firmware* that has a struct layout subject to compiler/arch padding
> > rules.
> I would also prefer explicitly adding the padding and leaving the rest 
> of the code as-is.
> 

Arguably, if you add padding explicitly, you might want to also mark it
__packed or add some BUILD_BUG_ON() ensuring there's no more padding
added by the compiler because of weird architectures, or whatnot?

johannes