Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <57feb4a99c835e6a70496e8e935501bb12a393b3.camel@mediatek.com>
Subject: Re: [PATCH v2 3/5] mt76: mt7915: add support for MT7986
From:   Peter Chiu <chui-hao.chiu@mediatek.com>
To:     Lorenzo Bianconi <lorenzo@kernel.org>
CC:     Felix Fietkau <nbd@nbd.name>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        "Xing Song" <xing.song@mediatek.com>,
        Sujuan Chen <sujuan.chen@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>,
        Bo Jiao <bo.jiao@mediatek.com>
Date:   Fri, 14 Jan 2022 10:21:58 +0800
In-Reply-To: <YeAvXzG6ueZWxoGa@lore-desk>
References: <cover.1641901681.git.Bo.Jiao@mediatek.com>
         <8b2098132192c0381e41ac78a47b7318d5c28b04.1641901681.git.Bo.Jiao@mediatek.com>
         <Yd7ZKb7Qsh4lGA5E@lore-desk>
         <2ab2731dc44494dbfe89363638cdcaf49351afbe.camel@mediatek.com>
         <Yd/8mXumr25iESux@lore-desk> <YeAvXzG6ueZWxoGa@lore-desk>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2022-01-13 at 14:55 +0100, Lorenzo Bianconi wrote:
> > > On Wed, 2022-01-12 at 14:35 +0100, Lorenzo Bianconi wrote:
> > > > > 
> > > > > @@ -302,6 +316,15 @@ struct mt7915_dev {
> > > > >  		u8 table_mask;
> > > > >  		u8 n_agrt;
> > > > >  	} twt;
> > > > > +
> > > > > +	struct reset_control *rstc;
> > > > > +	void __iomem *dcm;
> > > > > +	void __iomem *sku;
> > > > > +
> > > > > +	struct {
> > > > > +		bool is_7975;
> > > > > +		bool is_7976;
> > > > > +	} adie[MT7986_MAX_ADIE_NUM];
> > > > 
> > > > do we really need it? Can we just read data from chip when
> > > > necessary?
> > > > it is not
> > > > access in the hot-path, right?
> > > > I think it is easier and more readable.
> > > 
> > > Adie registers are inaccessible after wfsys power on so we need
> > > some
> > > places to store chip configuration.
> > > We will modify it to make it more readable.
> > > + u32 adie;
> > 
> > what I mean is just continue reading these values after the first
> > time (that is
> > in common for both approaches).
> 
> ok, sorry I misread your reply. Anyway it seems to me we need these
> values just
> in mt7986_wmac_enable() (or in routines called by
> mt7986_wmac_enable). Right?
> If so maybe we can just store them in a local struct in
> mt7986_wmac_enable().
> What do you think?
> 
OK, I will fix it in the next patch.

thanks,
Peter
> Regards,
> Lorenzo
> 
> > 
> > Regards,
> > Lorenzo
> > 
> > > 
> > > thanks,
> > > Peter
> > > 
> 
>