Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 14 Jan 2022 11:18:58 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Alexander Aring <alex.aring@gmail.com>
Cc:     Stefan Schmidt <stefan@datenfreihafen.org>,
        linux-wpan - ML <linux-wpan@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        Michael Hennerich <michael.hennerich@analog.com>,
        Harry Morris <h.morris@cascoda.com>,
        Varka Bhadram <varkabhadram@gmail.com>,
        Xue Liu <liuxuenetmail@gmail.com>, Alan Ott <alan@signal11.us>,
        David Girault <david.girault@qorvo.com>,
        Romuald Despres <romuald.despres@qorvo.com>,
        Frederic Blain <frederic.blain@qorvo.com>,
        Nicolas Schodet <nico@ni.fr.eu.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        "linux-wireless@vger.kernel.org Wireless" 
        <linux-wireless@vger.kernel.org>
Subject: Re: [wpan-next v2 06/27] net: mac802154: Set the symbol duration
 automatically
Message-ID: <20220114111858.117b3c9a@xps13>
In-Reply-To: <CAB_54W79S1gtNJtq+wzCig82KqauMXXOtdZ1VaNH97xXQEmUCQ@mail.gmail.com>
References: <20220112173312.764660-1-miquel.raynal@bootlin.com>
        <20220112173312.764660-7-miquel.raynal@bootlin.com>
        <CAB_54W79S1gtNJtq+wzCig82KqauMXXOtdZ1VaNH97xXQEmUCQ@mail.gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Alexander,

alex.aring@gmail.com wrote on Thu, 13 Jan 2022 18:36:15 -0500:

> Hi,
> 
> On Wed, 12 Jan 2022 at 12:33, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> ...
> > +               case IEEE802154_4030KHZ_MEAN_PRF:
> > +                       duration = 3974;
> > +                       break;
> > +               case IEEE802154_62890KHZ_MEAN_PRF:
> > +                       duration = 1018;
> > +                       break;
> > +               default:
> > +                       break;
> > +               }
> > +               break;
> > +       default:
> > +               break;
> > +       }
> > +
> > +set_duration:
> > +       if (!duration)
> > +               pr_debug("Unknown PHY symbol duration, the driver should be fixed\n");  
> 
> Why should the driver be fixed? It's more this table which needs to be fixed?

Right.

> 
> > +       else
> > +               phy->symbol_duration = duration;  
> 
> Can you also set the lifs/sifs period after the duration is known?

Done.

Thanks,
Miquèl