Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 15 Jan 2022 01:22:15 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     sean.wang@mediatek.com
Cc:     nbd@nbd.name, Soul.Huang@mediatek.com, YN.Chen@mediatek.com,
        Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com,
        Mark-YW.Chen@mediatek.com, Deren.Wu@mediatek.com,
        km.lin@mediatek.com, jenhao.yang@mediatek.com,
        robin.chiu@mediatek.com, Eddie.Chen@mediatek.com,
        ch.yeh@mediatek.com, posh.sun@mediatek.com, ted.huang@mediatek.com,
        Eric.Liang@mediatek.com, Stella.Chang@mediatek.com,
        Tom.Chou@mediatek.com, steve.lee@mediatek.com, jsiuda@google.com,
        frankgor@google.com, jemele@google.com, abhishekpandit@google.com,
        shawnku@google.com, linux-wireless@vger.kernel.org,
        linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 2/2] mt76: mt7921s: run sleep mode by default
Message-ID: <YeITtw2P89PN0nh8@lore-desk>
References: <c09673a115c39f7af692efb984a5dc0c75238a64.1642204233.git.objelf@gmail.com>
 <ddbc5499b76989c7d67fcbc31eb19ff535156dfa.1642204233.git.objelf@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3ZxKOMiV+WaUfZ/B"
Content-Disposition: inline
In-Reply-To: <ddbc5499b76989c7d67fcbc31eb19ff535156dfa.1642204233.git.objelf@gmail.com>
Precedence: bulk


--3ZxKOMiV+WaUfZ/B
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jan 15, Sean Wang wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>=20
> Apply sleep mode by default to reduce power consumption as possible.

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

>=20
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
> v1 -> v2: rebase on the top of
> 	  ("mt76: mt7921: toggle runtime-pm adding a monitor vif")
> ---
>  drivers/net/wireless/mediatek/mt76/mt7921/init.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/n=
et/wireless/mediatek/mt76/mt7921/init.c
> index 6059d8a0f227..fa6af85bba7b 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> @@ -226,14 +226,10 @@ int mt7921_register_device(struct mt7921_dev *dev)
>  	dev->pm.idle_timeout =3D MT7921_PM_TIMEOUT;
>  	dev->pm.stats.last_wake_event =3D jiffies;
>  	dev->pm.stats.last_doze_event =3D jiffies;
> -
> -	/* TODO: mt7921s run sleep mode on default  */
> -	if (mt76_is_mmio(&dev->mt76)) {
> -		dev->pm.enable_user =3D true;
> -		dev->pm.enable =3D true;
> -		dev->pm.ds_enable_user =3D true;
> -		dev->pm.ds_enable =3D true;
> -	}
> +	dev->pm.enable_user =3D true;
> +	dev->pm.enable =3D true;
> +	dev->pm.ds_enable_user =3D true;
> +	dev->pm.ds_enable =3D true;
> =20
>  	if (mt76_is_sdio(&dev->mt76))
>  		hw->extra_tx_headroom +=3D MT_SDIO_TXD_SIZE + MT_SDIO_HDR_SIZE;
> --=20
> 2.25.1
>=20

--3ZxKOMiV+WaUfZ/B
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYeITtwAKCRA6cBh0uS2t
rOMJAQDBplG0yTmRNOJh8aKzzetqboDPc3/i787qyVAhD/7pLQD8D4vV5TPSFZ9x
12jADQqQ6c9U0UgvJHAADexQfbIs8QE=
=dm9T
-----END PGP SIGNATURE-----

--3ZxKOMiV+WaUfZ/B--