Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2588377pxb; Mon, 17 Jan 2022 01:30:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJwxe4TQpIjLR/GkIO4WhwXwa/eoKPlWzroaYWbTntW7+gUjHbgZBNC/UQzSpV8de/RwO35H X-Received: by 2002:a17:902:6ac4:b0:14a:b3e8:6a14 with SMTP id i4-20020a1709026ac400b0014ab3e86a14mr5290037plt.163.1642411846218; Mon, 17 Jan 2022 01:30:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642411846; cv=none; d=google.com; s=arc-20160816; b=WSJpz04exOSliqheh+LuJPXl4va9mAEJUa/U1wrXCVrQbAMv9/I1TscPDikhiF3Tkn odWG77uIIyGMneaTDWF42dFEYtItiPi3ujiN2dDn8ClzE4IE2C0d4aXQOZgFUCmca/DI To4lkpUVvKBuYfRuv4dOnGCDJ0oSPBmbYx+J2N3k22I2mCh8fvOPOWNGSlSoeNfG6W3x l04Q4yO/otV+EWLdN/+HhseMEV3Kjl2uoGrgdMg4TYo8vr6DJz5nYHe0ZaOUbzfutNHJ iNeRp9mbjSGW0qOYg4L9bqr/KNCWRTSbf88S7+M+GNlhpTCwe79nzjkd3kamEGmjjUGA KrIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=zYcYhp1xOWC3T442rK4rWz6s6pHRMn4H6YuQOWanF2M=; b=i09ocZObgKPf2fQFehw+LXekEQf2LzxKvvmBZsv7bXZDklWpqDjno9jWYzoaprAPtp wRbHmU+jyhMZpe+ToTZ+r1yT1tBqXp3k2QAm4aMs2hodIgfEhd7NmQh3FRVrTLLrwasT In+7ioi0u89mkaSek9iPrpqoNIH6o30cSgxGjylgQlhQwJYZe7gUFC+lOOEyirUD+E7a UqY4lC7hgMDYhOvT70ysnWoGYYmNrpjEMtC1NTNK3tNv6+OxbI7gE19OPQ04mwjptUsG wAlF/2sEN1puHIty/dYPnyLKIPR0u6zbxqLQVMxJFOeRCbYcjTAJD2saD0vVOC9G6ygi qMwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m6si13812312pgc.435.2022.01.17.01.30.31; Mon, 17 Jan 2022 01:30:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233543AbiAPRzl (ORCPT + 70 others); Sun, 16 Jan 2022 12:55:41 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:42210 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S230174AbiAPRzl (ORCPT ); Sun, 16 Jan 2022 12:55:41 -0500 X-UUID: f68374cc18eb4596a787a7c59d07d1cf-20220117 X-UUID: f68374cc18eb4596a787a7c59d07d1cf-20220117 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 232353742; Mon, 17 Jan 2022 01:55:39 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Mon, 17 Jan 2022 01:55:38 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 17 Jan 2022 01:55:38 +0800 Message-ID: <5fdb8db1f02ffdacd554b7db531cf7719399cbdd.camel@mediatek.com> Subject: Re: [PATCH 4/5] mt76: connac: move he radiotap parsing in connac module From: Ryder Lee To: Lorenzo Bianconi , CC: , , Date: Mon, 17 Jan 2022 01:55:38 +0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sun, 2022-01-16 at 13:43 +0100, Lorenzo Bianconi wrote: > Move HE radiotap parsing code in mt76-connac module since it is > shared > between mt7921 and mt7915 drivers. > > Signed-off-by: Lorenzo Bianconi > --- > .../net/wireless/mediatek/mt76/mt76_connac.h | 2 + > .../wireless/mediatek/mt76/mt76_connac_mac.c | 168 ++++++++++++++++ > .../wireless/mediatek/mt76/mt76_connac_mac.h | 4 + > .../net/wireless/mediatek/mt76/mt7915/mac.c | 175 +--------------- > - [...] > +mt76_connac_mac_decode_he_mu_radiotap(struct sk_buff *skb, __le32 > *rxv) > +{ > + struct mt76_rx_status *status = (struct mt76_rx_status *)skb- > >cb; > + static const struct ieee80211_radiotap_he_mu mu_known = { > + .flags1 = HE_BITS(MU_FLAGS1_SIG_B_MCS_KNOWN) | > + HE_BITS(MU_FLAGS1_SIG_B_DCM_KNOWN) | > + HE_BITS(MU_FLAGS1_CH1_RU_KNOWN) | > + HE_BITS(MU_FLAGS1_SIG_B_SYMS_USERS_KNOWN) | > + HE_BITS(MU_FLAGS1_SIG_B_COMP_KNOWN), > + .flags2 = HE_BITS(MU_FLAGS2_BW_FROM_SIG_A_BW_KNOWN) | > + HE_BITS(MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN), I think hardware doesn't report MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN and MU_FLAGS1_SIG_B_COMP_KNOWN. Should align mt7915 here. Ryder