Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 16 Jan 2022 21:58:42 +0100
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Ryder Lee <ryder.lee@mediatek.com>
Cc:     nbd@nbd.name, lorenzo.bianconi@redhat.com,
        linux-wireless@vger.kernel.org, sean.wang@mediatek.com
Subject: Re: [PATCH 4/5] mt76: connac: move he radiotap parsing in connac
 module
Message-ID: <YeSHAhI5HzjKsuKx@lore-desk>
References: <cover.1642336806.git.lorenzo@kernel.org>
 <dcd7e4a9f10b1f0c94050453e4de4e1443fbc642.1642336806.git.lorenzo@kernel.org>
 <5fdb8db1f02ffdacd554b7db531cf7719399cbdd.camel@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="B+lTE28PY6x2jOAV"
Content-Disposition: inline
In-Reply-To: <5fdb8db1f02ffdacd554b7db531cf7719399cbdd.camel@mediatek.com>
Precedence: bulk


--B+lTE28PY6x2jOAV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On Sun, 2022-01-16 at 13:43 +0100, Lorenzo Bianconi wrote:
> > Move HE radiotap parsing code in mt76-connac module since it is
> > shared
> > between mt7921 and mt7915 drivers.
> >=20
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  .../net/wireless/mediatek/mt76/mt76_connac.h  |   2 +
> >  .../wireless/mediatek/mt76/mt76_connac_mac.c  | 168 ++++++++++++++++
> >  .../wireless/mediatek/mt76/mt76_connac_mac.h  |   4 +
> >  .../net/wireless/mediatek/mt76/mt7915/mac.c   | 175 +---------------
> > -
>=20
> [...]
>=20
> > +mt76_connac_mac_decode_he_mu_radiotap(struct sk_buff *skb, __le32
> > *rxv)
> > +{
> > +	struct mt76_rx_status *status =3D (struct mt76_rx_status *)skb-
> > >cb;
> > +	static const struct ieee80211_radiotap_he_mu mu_known =3D {
> > +		.flags1 =3D HE_BITS(MU_FLAGS1_SIG_B_MCS_KNOWN) |
> > +			  HE_BITS(MU_FLAGS1_SIG_B_DCM_KNOWN) |
> > +			  HE_BITS(MU_FLAGS1_CH1_RU_KNOWN) |
> > +			  HE_BITS(MU_FLAGS1_SIG_B_SYMS_USERS_KNOWN) |
> > +			  HE_BITS(MU_FLAGS1_SIG_B_COMP_KNOWN),
> > +		.flags2 =3D HE_BITS(MU_FLAGS2_BW_FROM_SIG_A_BW_KNOWN) |
> > +			  HE_BITS(MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN),
>=20
> I think hardware doesn't report MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN and
> MU_FLAGS1_SIG_B_COMP_KNOWN. Should align mt7915 here.

ack, thx for point this out.
@Sean: can you please confirm it?

Regards,
Lorenzo

>=20
> Ryder
>=20

--B+lTE28PY6x2jOAV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYeSHAgAKCRA6cBh0uS2t
rLzhAP9+kYBTz08W5sEWU2zfbv9MjHgHeV3ngm0b3I+cPrgbbAEA+UGECTGsIR78
o7vsXZTIAf0NbdCjvm8Iwi3nWRT0Lgg=
=Y8ZX
-----END PGP SIGNATURE-----

--B+lTE28PY6x2jOAV--