Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp2974116pxb; Mon, 17 Jan 2022 09:16:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxSozvpl3s09ACy+6qT2GC8JIMh3zmEG+tSJ0qZxreiCvaST7QBlY0v777lyL8UsioOxeSg X-Received: by 2002:a17:903:286:b0:14a:9ad7:9a02 with SMTP id j6-20020a170903028600b0014a9ad79a02mr12952560plr.109.1642439764964; Mon, 17 Jan 2022 09:16:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642439764; cv=none; d=google.com; s=arc-20160816; b=0kB9Anl46TjMvVVQB4/lhTl0KVN5+w/QFmA45alX9xMVzN3IBxCpsJmLTqkQfCgRR/ 0w+6fMoA8BevWg5N9Pzs4LBwVbMvDJE060d9FEUGxqrjL4agh7prP6OmBzio3W+pRDk6 dS8YlYWGdwqRzOkfW5gJbuwm38Bp6qmqRsTDy/YnnsjHDjNrxzAgNNizqJpil+50Zto0 3sVg7BJu0REZ5LlZbT+fB4/cpFe/TQSLZczWUThHFy0rdY5aDOmh/WcSkDvipjeGIHiT SeuqVLcsBYfIXO/ggbGbAQOVYiGdfAghBZS+KBhfxB7LyCrup0qAcrQuFZ/dknmjaf7y sH/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/sbARnj7NUujYJNJ1SxELiywTxebAIDmK7PdZyGB7mI=; b=qWfajSMattI4KUit5CqorzIWWNF2zCyW6YGHui7AGw/wHgSLjKIudeR7jrWiJ6BjqG DszMwpmhQgPIXPd+dQXUjnL1lGjlsUHuim5ww8DIA2u7aU79lIuhXS880ZIXOemGiDIR yk1Ef0DoqDGY9Dak4Z00V+Q/CrW2e1Z3P8mxlLwMzce7PRECNY8RutXDEIpx/L9wEM3k pjUcj2hq9QehpxnI3pbTHa4dRG1ziZGnxFJ4m4uTi1y79Z/mRJbKDD826ok/SAbPhchj J9bvxkzI5THK/+Pd/M2VX2ET8qbCr2eQpnWdxCt0vdQCT5vWsFUmeUBQI347plCBbLBy inqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d137si14777870pga.826.2022.01.17.09.15.54; Mon, 17 Jan 2022 09:16:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239331AbiAQLzX (ORCPT + 70 others); Mon, 17 Jan 2022 06:55:23 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:39685 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239315AbiAQLzO (ORCPT ); Mon, 17 Jan 2022 06:55:14 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 07B05200018; Mon, 17 Jan 2022 11:55:11 +0000 (UTC) From: Miquel Raynal To: Alexander Aring , Stefan Schmidt , linux-wpan@vger.kernel.org Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, David Girault , Romuald Despres , Frederic Blain , Nicolas Schodet , Michael Hennerich , Jakub Kicinski , Varka Bhadram , Xue Liu , Alan Ott , Thomas Petazzoni , Miquel Raynal Subject: [PATCH v3 15/41] net: ieee802154: Return meaningful error codes from the netlink helpers Date: Mon, 17 Jan 2022 12:54:14 +0100 Message-Id: <20220117115440.60296-16-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220117115440.60296-1-miquel.raynal@bootlin.com> References: <20220117115440.60296-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Returning -1 does not indicate anything useful. Use a standard and meaningful error code instead. Signed-off-by: Miquel Raynal --- net/ieee802154/nl802154.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c index 45e2c9b0505a..bd1015611a7e 100644 --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -1459,7 +1459,7 @@ static int nl802154_send_key(struct sk_buff *msg, u32 cmd, u32 portid, hdr = nl802154hdr_put(msg, portid, seq, flags, cmd); if (!hdr) - return -1; + return -ENOBUFS; if (nla_put_u32(msg, NL802154_ATTR_IFINDEX, dev->ifindex)) goto nla_put_failure; @@ -1652,7 +1652,7 @@ static int nl802154_send_device(struct sk_buff *msg, u32 cmd, u32 portid, hdr = nl802154hdr_put(msg, portid, seq, flags, cmd); if (!hdr) - return -1; + return -ENOBUFS; if (nla_put_u32(msg, NL802154_ATTR_IFINDEX, dev->ifindex)) goto nla_put_failure; @@ -1830,7 +1830,7 @@ static int nl802154_send_devkey(struct sk_buff *msg, u32 cmd, u32 portid, hdr = nl802154hdr_put(msg, portid, seq, flags, cmd); if (!hdr) - return -1; + return -ENOBUFS; if (nla_put_u32(msg, NL802154_ATTR_IFINDEX, dev->ifindex)) goto nla_put_failure; @@ -2006,7 +2006,7 @@ static int nl802154_send_seclevel(struct sk_buff *msg, u32 cmd, u32 portid, hdr = nl802154hdr_put(msg, portid, seq, flags, cmd); if (!hdr) - return -1; + return -ENOBUFS; if (nla_put_u32(msg, NL802154_ATTR_IFINDEX, dev->ifindex)) goto nla_put_failure; -- 2.27.0