Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3354142pxb; Mon, 17 Jan 2022 18:24:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJxjy8H6Nm7Sv+KPNpi+ghZLFjsN+oNinCs1LuL1vxzG2RCCgJt1e41u4SFrSUeuJteABLNe X-Received: by 2002:a62:384b:0:b0:4bd:ea83:95c5 with SMTP id f72-20020a62384b000000b004bdea8395c5mr23607047pfa.75.1642472663608; Mon, 17 Jan 2022 18:24:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642472663; cv=none; d=google.com; s=arc-20160816; b=YypEOeOR4I653WSOEwaSrfCcbUehSqLKjaSe1vYQMdsy047YqoZ9eowJtvPPfFQQ9j v9Jh+LJXauiY7qQVcmqAsej34VMZ+ZyP+SWQRn5g5p8Yv5W/TMBCncW+OryJ7FnJZHK2 LioIzOSWEAzxwUynAMuFyB/bX6qBYr6ZJ2TvRdHFphqzRjw3sok1QpRcPUFRymCpNXAU xNUyFGqryiBbGMgdUY8f1LnLtHRsux6qTrxlXO9qyX1dBlp9Ny1zXxPWHnIqR4/i6cRZ 5n6gRL4eoh8sr3GAccAhPxDnovFdXlltxuwzspWt1s8rWJ1vlUbVxqzTgEC6FplvVcYE X6+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=CEAVmDJgBRmQAJ7CqZ7tnvmX2jzt0oB5P8bPBMhj7n0=; b=F7a6rVhxK2sOe3MY3nj23lvYlOCwBxCglnoFz8DvHhbOMfy1wdt6d4wkAaW5LIGHG4 AZeo+MEvWJG4QNueVpV9DVqlaHyuDmRc8tEZAQakmB5rSvMkJ8aPXN1X6BSUCivtLIu0 I319Yje5E1r1SMsWwklOMN4knzvWWjQC2GAsYM5FWf/N7d0/GFQpa+Z3MTirJyqNtA0K 0bprbu+y6FRHq+WId1EZ2LXc219c/zrJ0EeAYnMz8+AR8kQUSgaanxpyaptziRFuPYMn DS0NUQVbbo1ccYQ1qMMBT6XOC0zxbPtmM0JDxY0n6vmKdWA4VtBJomjGcyvb9ApAb2Gd DIeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kOv0sLKA; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 2si15570688plg.262.2022.01.17.18.24.15; Mon, 17 Jan 2022 18:24:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kOv0sLKA; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239923AbiAQMhk (ORCPT + 70 others); Mon, 17 Jan 2022 07:37:40 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:42002 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234214AbiAQMhj (ORCPT ); Mon, 17 Jan 2022 07:37:39 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4E106B8104F; Mon, 17 Jan 2022 12:37:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDA05C36AE3; Mon, 17 Jan 2022 12:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642423057; bh=P/4ypUvSVoNhfvCVlcs6PIj/nztszYxr3tJXDpKx0AQ=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=kOv0sLKAWJuO36BaFW/clbJNKuy30V1303of+GpbLMpl4xrne2D+RS9TMJ98EtdSQ XIZFubm9zUuTnAPAttdoyJP1qu6XarL8Hr+gL9D9+wDt/WAjcMh9LGci5/m8XBUDrg zmFfsvkKG3gXwD+cm5SEmELvMby/J+CMj1l9Hg9fGZSP9aC2iEvV40pG25BU66kWao ryG8X2GUhMTKAPONFhpME76TTxQRcjkbilByqrIFFWwl/rHt/JyBgOfCFMfOCarcPD jdj8PkRoQr4/gIHeu4TWi6ik4WvwyLeOQjR/sETSJqgwjaKGE08qlUR4QK+lAljQOk +40GomMpyOnpQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath11k: fix error code in ath11k_qmi_assign_target_mem_chunk() From: Kalle Valo In-Reply-To: <20220111071445.GA11243@kili> References: <20220111071445.GA11243@kili> To: Dan Carpenter Cc: Anilkumar Kolli , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <164242305424.27899.2840074267453556270.kvalo@kernel.org> Date: Mon, 17 Jan 2022 12:37:35 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Carpenter wrote: > The "ret" vairable is not set at this point. It could be uninitialized > or zero. The correct thing to return is -ENODEV. > > Fixes: 6ac04bdc5edb ("ath11k: Use reserved host DDR addresses from DT for PCI devices") > Signed-off-by: Dan Carpenter > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. c9b41832dc08 ath11k: fix error code in ath11k_qmi_assign_target_mem_chunk() -- https://patchwork.kernel.org/project/linux-wireless/patch/20220111071445.GA11243@kili/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches