Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3354300pxb; Mon, 17 Jan 2022 18:24:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJxOMvpgYCL75xIxuQcC7Y4UIe+lsFYxTuraB5F3xtk8xqlngsa6LkQe/zejClOgsJll1z55 X-Received: by 2002:aa7:9e5a:0:b0:4bf:32da:b179 with SMTP id z26-20020aa79e5a000000b004bf32dab179mr23542993pfq.1.1642472681346; Mon, 17 Jan 2022 18:24:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642472681; cv=none; d=google.com; s=arc-20160816; b=wQkepS3dcMlr7lpvAG9Kk7vbscUB98eUZf9J4q6tn/Jl3EUn3HNuG6hp6SghbP5mdt EOSOZiiH0BdhMTqEIu+q5bzQD9ns+UkG2oTvA1Y50K+Oi53FdnLN4q4Kp0sfb2IB9xcB WQM313lvfLtE2JnagLRIEPdkRgZHhiqTdsPQ98JnkKXvkReBD/yvKrTZ7J1guhEWPGv/ IzRekUABUjXDNRurmtr7wmH+lJjpRYHzXI4A2HamEm+UO6k6lUt03YKZRrAwwe2C3eXR b3XXDzNbRqj3Z9rIiTs/q5L+XEx9NSoDMrTTTmzuccYXVQ6Hy4RQi0f376yMoiEvKaFA tBmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=GzL9ukcumlPC02xj+JWtKK12OjuEMLjn1YdULXp7hX4=; b=SvVSMRzap6D35AUULLmp7I5CLD4Ur4GklzbTs6krujdcRSCecNQ3Cha4+9KzBYu+Ri TWAYJUfQtqL9qpv8ZcyR2RBs+x2RbCMCbt1UaeqlSp5gOX+02mHokxneGvAN8m27rvk+ EDV7AHO94gZgZkr8AXjtVmPoDAPw4ZTmHOWplKASe5SFHAGf2mw5CCQGfhzk03lysVAg Y/g5jd0b6tdByCmCgNRNWpND77yWalpsDLjoH3p4jMQK/7L4QfQ+LShhABI/5WSbyrT4 EmoBhkcVIla/NgcSZM57Pu8CE6LF59qwg/xBWD815760OFzHITK9L5DbYEQUyIhb+mzS pGZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SLgRxz0j; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i17si9389170pgn.601.2022.01.17.18.24.33; Mon, 17 Jan 2022 18:24:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SLgRxz0j; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239954AbiAQMmA (ORCPT + 70 others); Mon, 17 Jan 2022 07:42:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234166AbiAQMmA (ORCPT ); Mon, 17 Jan 2022 07:42:00 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAFF0C061574; Mon, 17 Jan 2022 04:41:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 77858611B5; Mon, 17 Jan 2022 12:41:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28955C36AE3; Mon, 17 Jan 2022 12:41:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642423318; bh=GpsA3cbs+BIbsadEtt95gl6TWxIcj8Lx14iqogGceHc=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=SLgRxz0jYUozJHlYpOvrK5lXePGyEUShn5V3MEMWjvF68cQ1jJikHw5FFddlprM1h KxH+T3knOufWzZNA0nF/D5hoSnjf3ma5gqAtd4+8kedEcfGm54gHYikanjBq2DNaGD TUnMbcqR1dtT61CU8d4NUpkP0+JtxS/PNmuq/Li/vaPDPLTOBZSQae6A0Kcb00P/Xo Xzcs4gnPVtj365qmViZ2qY23RgyowYBSFSnPgL/mUk46y+iqWowLB5/MJTGm0UHhXe RQiY0EjPkZymfRbenbk8yMkXdj9uzMnfdNmIrNZhCt5bXmRgR6QafJgJpIk5iWN0Xt 3neOnVofSjmbQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath: dfs_pattern_detector: Avoid open coded arithmetic in memory allocation From: Kalle Valo In-Reply-To: <0fbcd32a0384ac1f87c5a3549e505e4becc60226.1640624216.git.christophe.jaillet@wanadoo.fr> References: <0fbcd32a0384ac1f87c5a3549e505e4becc60226.1640624216.git.christophe.jaillet@wanadoo.fr> To: Christophe JAILLET Cc: davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <164242331548.27899.9932446295681799332.kvalo@kernel.org> Date: Mon, 17 Jan 2022 12:41:56 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Christophe JAILLET wrote: > kmalloc_array()/kcalloc() should be used to avoid potential overflow when > a multiplication is needed to compute the size of the requested memory. > > kmalloc_array() can be used here instead of kcalloc() because the array is > fully initialized in the next 'for' loop. > > Finally, 'cd->detectors' is defined as 'struct pri_detector **detectors;'. > So 'cd->detectors' and '*cd->detectors' are both some pointer. > So use a more logical 'sizeof(*cd->detectors)'. > > Signed-off-by: Christophe JAILLET > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. a063b650ce5d ath: dfs_pattern_detector: Avoid open coded arithmetic in memory allocation -- https://patchwork.kernel.org/project/linux-wireless/patch/0fbcd32a0384ac1f87c5a3549e505e4becc60226.1640624216.git.christophe.jaillet@wanadoo.fr/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches