Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3354814pxb; Mon, 17 Jan 2022 18:25:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwqwB1fPmaqHGUf5a4aUs4SFRdSgAP4ruySGzYvniArhJQUCGyqCPu3kBbEwAkA3WUK//4M X-Received: by 2002:a17:902:bb97:b0:144:d5cb:969f with SMTP id m23-20020a170902bb9700b00144d5cb969fmr25264230pls.36.1642472722729; Mon, 17 Jan 2022 18:25:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642472722; cv=none; d=google.com; s=arc-20160816; b=W4NQCURIQViZTJPaH8FdgEQnszm/y0gTWwHYUtw7U0jZHk0zVWqD7IzP7ocJpP/87F 6mlhUR5xwahZ5vSqpuU0l9Ywv/uZHspdq/v7LQXkrtCEtvXqw5WoSk3jpJEtROe115FM lCupssYsiecJUKPlpOPYl4laQKDhTFXp280bBA7cyVEFEK8BQN6vBFQmfyOUeho5PXdt iLfsDgAF1RV2hfQvq9l1RWhZAp6ApclT9YAidyi7C/z3PeU+ld+I8AdEeG1dfjojnWZe gpjqpB65i+V88+MIh9MwrbQ6+eJ0emk1ohvegsBeIXxG6BkllN4XXxafJGtoLpeH3ZL6 SKZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=Xes1toGS6XJrMRlPRsCdMtLKuxCfKgs3rWlYyEFdOAo=; b=JAupKwaEhsbzO921OJJUi9vfy9m1+MBw4yUT1myvDL5Vq9SQS1c0vKkgaClSwSn9p8 UUFa5O5H9cB1yuqWKvwGvoJ1fRBfJcCvdfAfP1DbP2WiwKiERisV2mqcQGmiCTlAYLmI zcsOqFNN8z1zv7EP/wDQM/mTsRwoge85Vp0TIYH05ctH/7FjqUJXcsznA9RnM5OIanSK ZF+Af39JJqhD3MiwGqqlXoDuryueaOTxhXDHVUwtNZZfnez/RPxBQPL+o4QmCr7QOqg7 ea+B2KKq35w+7DIHl16dH48vCm+PBNNemyp8Mb5y2Uz1Yjb84pet2Lt1cWDSmauEAq23 5tYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f945m6NR; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c3si7471603pfv.129.2022.01.17.18.25.14; Mon, 17 Jan 2022 18:25:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f945m6NR; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230335AbiAQMp2 (ORCPT + 70 others); Mon, 17 Jan 2022 07:45:28 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:45108 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229979AbiAQMp1 (ORCPT ); Mon, 17 Jan 2022 07:45:27 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7132BB8104D for ; Mon, 17 Jan 2022 12:45:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6063C36AEC; Mon, 17 Jan 2022 12:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642423525; bh=diarlsjyUeuHowtNNVWY50r6KaQgdnsyfvtUVtB0cRk=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=f945m6NRc/sDfkf+EqVFH+3i5UY+QfdPJEs7DNmMrT2nYK5dlHe8sNrAIHRIKDEFc oGwLziwfH0szK9dYa3NBHuP/walWmjHKcL9qYhxZ+baYL2WDhxq9SVE2OfnkF+Vh42 a2qW5V977A+51f7b2jEnMKm8iXY88b+lXN65bjXxMohMjrwDkqol1kLnMx8j6inM+0 g9eCP0GAkFl1WRotqMa7DoNC+xZee7VfVHmLtUNUIQxXbFE2A97c+yPipkts34dwK+ dMBsSpUYrvcvbrSDVMGsRoQXzurLUqPBzNfQvKvFESmSQSbuND1txI4fHXLplYBl/V ZxfG9qBiXpJVg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] ath10k: abstract htt_rx_desc structure From: Kalle Valo In-Reply-To: <20211216151823.68878-1-franciman12@gmail.com> References: <20211216151823.68878-1-franciman12@gmail.com> To: Francesco Magliocca Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, enrico@fracta.dev, Francesco Magliocca User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <164242352076.27899.16661550947975191712.kvalo@kernel.org> Date: Mon, 17 Jan 2022 12:45:23 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Francesco Magliocca wrote: > QCA6174 card often hangs with the current htt_rx_desc > memory layout in some circumstances, because its firmware > fails to handle length differences. > Therefore we must abstract the htt_rx_desc structure > and operations on it, to allow different wireless cards > to use different, unrelated rx descriptor structures. > > Define a base htt_rx_desc structure and htt_rx_desc_v1 > for use with the QCA family of ath10k supported cards > and htt_rx_desc_v2 for use with the WCN3990 card. > > Define htt_rx_desc_ops which contains the abstract operations > to access the generic htt_rx_desc, give implementations > for each card and update htt_rx.c to use the defined > abstract interface to rx descriptors. > > Fixes: e3def6f7ddf8 ("ath10k: Update rx descriptor for WCN3990 target") > > Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00157-QCARMSWPZ-1 > > Co-developed-by: Enrico Lumetti > Signed-off-by: Enrico Lumetti > Signed-off-by: Francesco Magliocca > Link: https://lore.kernel.org/ath10k/CAH4F6usFu8-A6k5Z7rU9__iENcSC6Zr-NtRhh_aypR74UvN1uQ@mail.gmail.com/ > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 6bae9de622d3 ath10k: abstract htt_rx_desc structure -- https://patchwork.kernel.org/project/linux-wireless/patch/20211216151823.68878-1-franciman12@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches